[apps-discuss] apps-team review of draft-das-mipshop-andsf-dhcp-options

Claudio Allocchio <Claudio.Allocchio@garr.it> Mon, 06 September 2010 14:59 UTC

Return-Path: <claudio.allocchio@garr.it>
X-Original-To: apps-discuss@core3.amsl.com
Delivered-To: apps-discuss@core3.amsl.com
Received: from localhost (localhost [127.0.0.1]) by core3.amsl.com (Postfix) with ESMTP id 2FF4E3A6819 for <apps-discuss@core3.amsl.com>; Mon, 6 Sep 2010 07:59:06 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: 1.881
X-Spam-Level: *
X-Spam-Status: No, score=1.881 tagged_above=-999 required=5 tests=[BAYES_50=0.001, HELO_EQ_IT=0.635, HOST_EQ_IT=1.245]
Received: from mail.ietf.org ([64.170.98.32]) by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ErsgHSG6JeQW for <apps-discuss@core3.amsl.com>; Mon, 6 Sep 2010 07:59:05 -0700 (PDT)
Received: from cyrus.dir.garr.it (cyrus.dir.garr.it [IPv6:2001:760:0:158::29]) by core3.amsl.com (Postfix) with ESMTP id 1BF2D3A67B5 for <apps-discuss@ietf.org>; Mon, 6 Sep 2010 07:59:03 -0700 (PDT)
Received: from mac-allocchio3.elettra.trieste.it (mac-allocchio3.elettra.trieste.it [140.105.2.18]) by cyrus.dir.garr.it (8.14.4/8.14.4) with ESMTP id o86ExTo8057839 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for <apps-discuss@ietf.org>; Mon, 6 Sep 2010 16:59:29 +0200 (CEST)
Date: Mon, 06 Sep 2010 16:40:47 +0200
From: Claudio Allocchio <Claudio.Allocchio@garr.it>
X-X-Sender: claudio@mac-allocchio3.elettra.trieste.it
To: apps-discuss@ietf.org, subir@research.Telcordia.com, gabor.bajko@nokia.com, vijay@wichorus.com, iesg@ietf.org
Message-ID: <Pine.OSX.4.64.1009061616080.2959@mac-allocchio3.elettra.trieste.it>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset="US-ASCII"; format="flowed"
ReSent-Date: Mon, 06 Sep 2010 16:59:20 +0200
ReSent-From: Claudio Allocchio <claudio.allocchio@garr.it>
ReSent-To: apps-discuss@ietf.org
ReSent-Subject: apps-team review of draft-das-mipshop-andsf-dhcp-options
ReSent-Message-ID: <Pine.OSX.4.64.1009061659200.2959@mac-allocchio3.elettra.trieste.it>
Subject: [apps-discuss] apps-team review of draft-das-mipshop-andsf-dhcp-options
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/apps-discuss>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 06 Sep 2010 14:59:06 -0000

I have been selected as the Applications Area Review Team reviewer for 
this draft (for background on apps-review, please see 
http://www.apps.ietf.org/content/applications-area-review-team).

Please resolve these comments along with any other Last Call comments you 
may receive. Please wait for direction from your document shepherd or AD 
before posting a new version of the draft.

Document: draft-das-mipshop-andsf-dhcp-options
Reviewer: Claudio Allocchio (GARR, Italian Research and Academic Network)
Review Date: 2010-09-06
IETF Last Call Date: 2010-08-09 (?)
IESG Telechat Date: 2010-09-09

Summary: This draft has not any specific Application Area issues (use of 
XML, date/time format, URIs, Internationalization conformance, IDNA, 
etc.), hence fro this point of view it is ready for publication as 
Proposed Standard.

Major Issues: None.

Minor Issues:

- section 2: maybe I'm just overconcerned with clarity, but I would 
rephrase the second senctence and schema repeating "IPv4 address" instead 
of only "IP address(es)"

The Option begins with an option code followed by a length and one
or more IPv4 addresses. The option layout is depicted below:

      0  1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1 2 3 4 5 6 7 8 9 0 1
                                      +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
                                      | Option Code   |    Length     |
      +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
      |                     IPv4 Address                              |
      .                                                               .
      +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

- Section 3:

same as above: use "IPv6 address(es)" all the time, instead of only "IP 
address(es)".

Nits: None.

I hope this helps!   ;-)

Best Regards!
Claudio

------------------------------------------------------------------------------
Claudio Allocchio             G   A   R   R          Claudio.Allocchio@garr.it
                         Senior Technical Officer
tel: +39 040 3758523      Italian Academic and       G=Claudio; S=Allocchio;
fax: +39 040 3758565        Research Network         P=garr; A=garr; C=it;

            PGP Key: http://www.cert.garr.it/PGP/keys.php3#ca