[apps-discuss] Apps-team review of draft-ietf-dime-extended-naptr-06

Joseph Yee <jyee@afilias.info> Sun, 24 April 2011 16:29 UTC

Return-Path: <jyee@afilias.info>
X-Original-To: apps-discuss@ietfc.amsl.com
Delivered-To: apps-discuss@ietfc.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfc.amsl.com (Postfix) with ESMTP id E8FAEE05F5 for <apps-discuss@ietfc.amsl.com>; Sun, 24 Apr 2011 09:29:00 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -6.265
X-Spam-Level:
X-Spam-Status: No, score=-6.265 tagged_above=-999 required=5 tests=[AWL=-0.000, BAYES_00=-2.599, IP_NOT_FRIENDLY=0.334, RCVD_IN_DNSWL_MED=-4]
Received: from mail.ietf.org ([208.66.40.236]) by localhost (ietfc.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DPr1xUkFlGcw for <apps-discuss@ietfc.amsl.com>; Sun, 24 Apr 2011 09:29:00 -0700 (PDT)
Received: from outbound.afilias.info (outbound.afilias.info [69.46.124.26]) by ietfc.amsl.com (Postfix) with ESMTP id 01360E062B for <Apps-Discuss@ietf.org>; Sun, 24 Apr 2011 09:28:59 -0700 (PDT)
Received: from ms5.yyz2.afilias-ops.info ([10.50.129.111] helo=smtp.afilias.info) by outbound.afilias.info with esmtp (Exim 4.69) (envelope-from <jyee@afilias.info>) id 1QE2B6-0007eL-3e for Apps-Discuss@ietf.org; Sun, 24 Apr 2011 16:28:56 +0000
Received: from mail-iw0-f178.google.com ([209.85.214.178]) by smtp.afilias.info with esmtps (TLSv1:RC4-SHA:128) (Exim 4.72) (envelope-from <jyee@afilias.info>) id 1QE2B5-0008Ga-6B for Apps-Discuss@ietf.org; Sun, 24 Apr 2011 16:28:55 +0000
Received: by iwn9 with SMTP id 9so1537506iwn.9 for <Apps-Discuss@ietf.org>; Sun, 24 Apr 2011 09:28:55 -0700 (PDT)
Received: by 10.42.75.65 with SMTP id z1mr3580378icj.132.1303662533840; Sun, 24 Apr 2011 09:28:53 -0700 (PDT)
Received: from [192.168.1.104] (69-196-182-49.dsl.teksavvy.com [69.196.182.49]) by mx.google.com with ESMTPS id t1sm1906133ibm.38.2011.04.24.09.28.51 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 24 Apr 2011 09:28:52 -0700 (PDT)
From: Joseph Yee <jyee@afilias.info>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Date: Sun, 24 Apr 2011 12:28:50 -0400
Message-Id: <EBA57BD3-C879-4B2F-8AB4-4509DC8D9E59@afilias.info>
To: Apps-Discuss@ietf.org, mark@azu.ca, jouni.nospam@gmail.com, lionel.morand@orange-fpgroup.com
Mime-Version: 1.0 (Apple Message framework v1084)
X-Mailer: Apple Mail (2.1084)
Subject: [apps-discuss] Apps-team review of draft-ietf-dime-extended-naptr-06
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/apps-discuss>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 24 Apr 2011 16:29:01 -0000

We have been selected as the Applications Area Review Team reviewer for this draft (for background on apps-review, please 
seehttp://www.apps.ietf.org/content/applications-area-review-team).


Please resolve these comments along with any other Last Call comments you may receive. Please wait for direction from your document shepherd or AD before posting a new version of the draft.

Document: draft-ietf-dime-extended-naptr-06

Title: Diameter S-NAPTR Usage

Reviewers: Julian Reschke, Joseph Yee

Review Date: April 23, 2011

Summary: This draft is almost ready for publication as Standard Track RFC but has a few issues that should be fixed before publication

Major Issues: 

     "app-protocol" is defined optional rather mandatory in current draft       
     This draft adopts the model from RFC3958, where app-protocol is optional. Not a Diameter myself, but I am under impression that this draft intends to make app-protocol mandatory. The previous model (RFC3588) always advertise the transport protocol (D2S or D2T).  If app-protocol is mandatory, add text (to Section 3, IMHO) to ensure it to readers.  If app-protocol is optional, please disregard this issue, but I would suggest to expand Section 5 (query procedure steps).


Minor Issues: 

     Section 3:
     iana-registered-service = aaa-service / ALPHA *31ALPHANUMSYM
     aaa-service             = "aaa+ap" appln-id
     appln-id                = DIGIT *DIGIT
                               ; Application identifier expressed as a
                               ; decimal integer.

1) Is "aaa+ap" case-insensitive? (That's the ABNF default for string literals)

2) Maybe "1*DIGIT" instead of "DIGIT *DIGIT"?

     iana-registered-protocol = aaa-protocol / ALPHA *31ALPHANUMSYM
     aaa-protocol             = "diameter." aaa-transport
     aaa-transport            = "tcp" / "sctp" / "tls.tcp"


Nits:
     None