[apps-discuss] APPSDIR review of draft-claise-export-application-info-in-ipfix-05
"Jiankang YAO" <yaojk@cnnic.cn> Fri, 20 April 2012 02:03 UTC
Return-Path: <yaojk@cnnic.cn>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 6BCBA21F8675 for <apps-discuss@ietfa.amsl.com>; Thu, 19 Apr 2012 19:03:57 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -100.102
X-Spam-Level:
X-Spam-Status: No, score=-100.102 tagged_above=-999 required=5 tests=[AWL=-0.744, BAYES_05=-1.11, MIME_BASE64_TEXT=1.753, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xm62buR1h62t for <apps-discuss@ietfa.amsl.com>; Thu, 19 Apr 2012 19:03:57 -0700 (PDT)
Received: from cnnic.cn (smtp.cnnic.cn [159.226.7.146]) by ietfa.amsl.com (Postfix) with SMTP id C632F21F866A for <apps-discuss@ietf.org>; Thu, 19 Apr 2012 19:03:55 -0700 (PDT)
X-EYOUMAIL-SMTPAUTH: yaojk@cnnic.cn
Received: from unknown127.0.0.1 (HELO lenovo47e041cf) (127.0.0.1) by 127.0.0.1 with SMTP; Fri, 20 Apr 2012 10:03:49 +0800
Message-ID: <C0E11F4B11154B1A8B40374C1E55C65E@LENOVO47E041CF>
From: Jiankang YAO <yaojk@cnnic.cn>
To: apps-discuss@ietf.org, bclaise@cisco.com, paitken@cisco.com, nirbd@cisco.com
Date: Fri, 20 Apr 2012 10:03:48 +0800
MIME-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: base64
X-Priority: 3
X-MSMail-Priority: Normal
X-Mailer: Microsoft Outlook Express 6.00.2900.5931
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157
Cc: iesg@ietf.org
Subject: [apps-discuss] APPSDIR review of draft-claise-export-application-info-in-ipfix-05
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/apps-discuss>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Apr 2012 02:03:57 -0000
I have been selected as the Applications Area Directorate reviewer for this draft (for background on AppsDir, please see http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate ). Please resolve these comments along with any other Last Call comments you may receive. Please wait for direction from your document shepherd or AD before posting a new version of the draft. Document: draft-claise-export-application-info-in-ipfix-05 Title: Export of Application Information in IPFIX Reviewer: Jiankang Yao Review Date: April 20, 2012 Summary: This document is almost ready for publication as a Informational RFC. This draft specifies an extension to the IPFIX information model specified in [RFC5102] to export application information. Minor issue: In Section 6: 6. Application Id Examples................................. 21 6.1. Example 1: Layer 2 Protocol........................ 21 6.2. Example 2: Standardized IANA Layer 3 Protocol...... 22 6.3. Example 3: Proprietary Layer 3 Protocol............ 23 6.4. Example 4: Standardized IANA Layer 4 Port.......... 25 6.5. Example 4: Layer 7 Application..................... 26 6.6. Example: port Obfuscation.......................... 28 6.7. Example: Application Mapping Options Template...... 29 6.8. Example: Attributes Values Options Template Record. 30 Comments : This section is all about examples, covering 10 pages. I suggest to move it to the appendix of this document since it does not specify anything. Discussion issue: In section 2 " Application could be defined at different OSI layers, from layer 2 to layer 7. For example: Link Layer Distribution Protocol (LLDP) [LLDP] is layer 2 application, ICMP is layer 3 application [IANA-PROTO], HTTP is layer 4 application [IANA-PORTS], and skype is layer 7. " Comments: From my understanding, HTTP is a kind of layer 7 application based on OSI, but it can be identified in layer 4. If my understanding is correct, I suggest to tune the text to the following: " Application could be identified at different OSI layers, from layer 2 to layer 7. For example: Link Layer Distribution Protocol (LLDP) [LLDP] can be identified in layer 2, ICMP is can be identified in layer 3 [IANA-PROTO], HTTP can be identified in layer 4 [IANA-PORTS], and skype can be identified in layer7. " In the rest of document, it need to be tuned accordingly too. Nits: Section6.5. title: Example 4: Layer 7 Application Change it to "Example 5: Layer 7 Application" since section 6.4 title is " Example 4: Standardized IANA Layer 4 Port"? Jiankang Yao
- [apps-discuss] APPSDIR review of draft-claise-exp… Jiankang YAO
- Re: [apps-discuss] APPSDIR review of draft-claise… Barry Leiba
- Re: [apps-discuss] APPSDIR review of draft-claise… Benoit Claise
- Re: [apps-discuss] APPSDIR review of draft-claise… Peter Saint-Andre
- Re: [apps-discuss] APPSDIR review of draft-claise… Murray S. Kucherawy
- Re: [apps-discuss] APPSDIR review of draft-claise… Benoit Claise
- Re: [apps-discuss] APPSDIR review of draft-claise… Barry Leiba