[apps-discuss] APPSDIR review of draft-harkins-brainpool-ike-groups-04
S Moonesamy <sm+ietf@elandsys.com> Wed, 06 February 2013 23:45 UTC
Return-Path: <sm@elandsys.com>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id E40AF21F85AE; Wed, 6 Feb 2013 15:45:01 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -102.59
X-Spam-Level:
X-Spam-Status: No, score=-102.59 tagged_above=-999 required=5 tests=[AWL=0.009, BAYES_00=-2.599, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([64.170.98.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rq0yHM+Sv6JK; Wed, 6 Feb 2013 15:45:00 -0800 (PST)
Received: from mx.ipv6.elandsys.com (mx.ipv6.elandsys.com [IPv6:2001:470:f329:1::1]) by ietfa.amsl.com (Postfix) with ESMTP id 51B5421F85A0; Wed, 6 Feb 2013 15:44:59 -0800 (PST)
Received: from SUBMAN.elandsys.com ([197.224.130.194]) (authenticated bits=0) by mx.elandsys.com (8.14.5/8.14.5) with ESMTP id r16Nijcc005892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Feb 2013 15:44:55 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=opendkim.org; s=mail2010; t=1360194298; bh=VJI6w1dlrApuMo5ay9WvzusnfT6H5uki3pIvtIX9qeY=; h=Date:To:From:Subject:Cc; b=Gv2NN/iSZOIx83yCJh4e56noahfxT0yUwpPTcyJMGZJHEGv/UU1hv+Zr0JQIYnvMT 9kZISqE/j3RLK3xal+o3XE3jMzxl+396855q6Xroja7yFWXOruRX0GVMY/28obbfW3 Srpg2aIpI+tdTp+GzU4eE810rk9ORYpgTXfOsMW8=
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=elandsys.com; s=mail; t=1360194298; i=@elandsys.com; bh=VJI6w1dlrApuMo5ay9WvzusnfT6H5uki3pIvtIX9qeY=; h=Date:To:From:Subject:Cc; b=AdrdoWkEFkIXz2pnIoLsGt/L8oWjKK7crZYgY4fbU0XR7IfnlwH0nkc14afSkNTsD hRACxkzqCUwtsoborkjQOw85IFO1h3rbJnezKrMK3zKfJPGOBx+pJCh3MEuhtB2Vf3 unXjdp5Wpu2ia8fjhsRRmypI2VE8SnbkUBWVN7Zg=
Message-Id: <6.2.5.6.2.20130206143103.0b18b460@elandnews.com>
X-Mailer: QUALCOMM Windows Eudora Version 6.2.5.6
Date: Wed, 06 Feb 2013 15:41:35 -0800
To: apps-discuss@ietf.org, draft-harkins-brainpool-ike-groups.all@tools.ietf.org, Johannes Merkle <johannes.merkle@secunet.com>
From: S Moonesamy <sm+ietf@elandsys.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; format="flowed"
Cc: iesg@ietf.org
Subject: [apps-discuss] APPSDIR review of draft-harkins-brainpool-ike-groups-04
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/apps-discuss>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Feb 2013 23:45:02 -0000
I have been selected as the Applications Area Directorate reviewer for this draft (for background on APPSDIR, please see http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate ). Please resolve these comments along with any other Last Call comments you may receive. Please wait for direction from your document shepherd or AD before posting a new version of the draft. Document: draft-harkins-brainpool-ike-groups-04 Title: Brainpool Elliptic Curves for the IKE Group Description Registry Reviewer: S. Moonesamy Review Date: February 6, 2013 IETF Last Call Date: January 31, 2013 Summary: This draft is almost ready for publication as an Informational RFC This memo allocates code points for four new elliptic curve domain parameter sets over finite prime fields into a registry that was established by The Internet Key Exchange (IKE) but is used by other protocols. One of the informational references mention that "the 224 bit curve brainpoolP224r1 and the 256 bit curve brainpoolP256r1 described below will be used in the new German machine readable travel documents (MRTDs) that follow ICAO technical reports". I did not verify the test vectors. I did not find any application considerations in the memo. Major issues: None Minor issues: In Section 4: "Implementations that desire to use the twisted curves internally MUST refer to [RFC5639] for the complete domain parameter sets, only the "twist" is defined here." I suggest using "must" and leaving it to RFC 5639 to specify the requirement. In Section 3: "These assigned values SHALL be identical to those being assigned to identical curves that are being added to a similar registry by [BPIKEV2]." I don't see a reason for a "SHALL" in the IANA Considerations Section. I suggest framing this as a request and removing the RFC 2119 boilerplate. The details can easily be worked out with IANA folks. "IANA is further instructed to update the "Group desription" portion of the [IANA-IKE] registry by appending Table 1 to the registry table and replace the words "this memo" (including the quotes) with a reference to the RFC number assigned to this memo." Typo: description. I read http://www.iana.org/assignments/ipsec-registry/ipsec-registry.xml#ipsec-registry-9 I didn't understand the "not for RFC 2409" in Table 1 at first. I gather that this is about the administrative prohibition mentioned in Section 5. I suggest clarifying the note. Nits: These are editorial nits. I would move Section 5 before Section 3 as it makes the memo clearer to me. In Section 1: "[RFC5639] defines new elliptic curve domain parmaeters for curves" Typo: parameters In Section 2: Typo: arithmatical In Section 4: "discrete logarithm cryptography, for example elliptic curve" Typo: cryptography There is a typo for "Californaia". Regards, S. Moonesamy