IETF Logo Mail Archive

[apps-discuss] APPSDIR review of draft-ietf-dime-realm-based-redirect-11

Enrico Marocco <enrico.marocco@telecomitalia.it> Wed, 28 August 2013 09:02 UTC

Return-Path: <enrico.marocco@telecomitalia.it>
X-Original-To: apps-discuss@ietfa.amsl.com
Delivered-To: apps-discuss@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 861FE11E826C; Wed, 28 Aug 2013 02:02:58 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.719
X-Spam-Level:
X-Spam-Status: No, score=-101.719 tagged_above=-999 required=5 tests=[BAYES_00=-2.599, HELO_EQ_IT=0.635, HOST_EQ_IT=1.245, RCVD_IN_DNSWL_LOW=-1, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id aVm4haM-GIEy; Wed, 28 Aug 2013 02:02:54 -0700 (PDT)
Received: from GRFEDG702RM001.telecomitalia.it (grfedg702rm001.telecomitalia.it [217.169.121.21]) by ietfa.amsl.com (Postfix) with ESMTP id E23FB11E8170; Wed, 28 Aug 2013 02:02:52 -0700 (PDT)
Received: from grfhub701rm001.griffon.local (10.19.3.8) by GRFEDG702RM001.telecomitalia.it (10.173.88.21) with Microsoft SMTP Server (TLS) id 8.3.297.1; Wed, 28 Aug 2013 11:02:51 +0200
Received: from MacLab.local (10.229.8.70) by smtp.telecomitalia.it (10.19.9.234) with Microsoft SMTP Server (TLS) id 8.3.297.1; Wed, 28 Aug 2013 11:02:50 +0200
Message-ID: <521DBCB9.7010406@telecomitalia.it>
Date: Wed, 28 Aug 2013 11:02:49 +0200
From: Enrico Marocco <enrico.marocco@telecomitalia.it>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8
MIME-Version: 1.0
To: "apps-discuss@ietf.org" <apps-discuss@ietf.org>, draft-ietf-dime-realm-based-redirect.all@tools.ietf.org
Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg="sha1"; boundary="------------ms050703000106040307090109"
X-TI-Disclaimer: Disclaimer1
Cc: IESG <iesg@ietf.org>
Subject: [apps-discuss] APPSDIR review of draft-ietf-dime-realm-based-redirect-11
X-BeenThere: apps-discuss@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: General discussion of application-layer protocols <apps-discuss.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/apps-discuss>
List-Post: <mailto:apps-discuss@ietf.org>
List-Help: <mailto:apps-discuss-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/apps-discuss>, <mailto:apps-discuss-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Aug 2013 09:02:58 -0000

I have been selected as the Applications Area Directorate reviewer for
this draft (for background on APPSDIR, please see
http://trac.tools.ietf.org/area/app/trac/wiki/ApplicationsAreaDirectorate ).

Please resolve these comments along with any other Last Call comments
you may receive. Please wait for direction from your document shepherd
or AD before posting a new version of the draft.

Document: draft-ietf-dime-realm-based-redirect-11
Title: Realm-Based Redirection In Diameter
Reviewer: Enrico Marocco
Review Date: August 28, 2013
IETF Last Call Date: August 27, 2013

Summary: This draft is almost ready for publication as a Proposed
Standard RFC but has one major (easy-to-fix) issue and a minor issue
that should be fixed before publication.

Major issues:

In S. 3.4, both in title and body (easy fix, but "Major" in that it's
about a crucial part of the specified mechanism):

  s/DIAMETER_REDIRECT_INDICATION/DIAMETER_REALM_REDIRECT_INDICATION/


Minor issues:

The document makes use of general terms such as "application", "domain",
"realm" and "identity" that have a specific meaning in the Diameter
context, but it does not provide explicit definitions. It would be
useful if the document provided a list of Diamaeter-specific terms, and
a pointer to where they are defined. I suggest adding to the Terminology
section something along the line of:

  This document uses the terms "application", "realm", "domain",
  "identity" [..] consistently with the definitions provided in RFC
  6733 (Section 1.2, Section 1.3.4, Section 2.6, [..]).


Nits:

This review does not include editorial nits.

v2.23.0 | Report a Bug | By Email