Re: [dccp] Re: Updated DCCP tcpdump patch

[Yoshifumi Nishida <nishida at csl.sony.co.jp>]

Hello Ian, 

Thanks for merging my code.
The patch you made looks good!

Cheers,
--
Yoshifumi Nishida
nishida at csl.sony.co.jp

From: Ian McDonald <iam4 at cs.waikato.ac.nz>
Subject: [dccp] Re: Updated DCCP tcpdump patch
Date: Thu, 04 Aug 2005 15:06:16 +1200
Message-ID: <42F18628.6050305 at cs.waikato.ac.nz>

 > Nishida-san,
 > 
 > I have updated this patch further due to a few things:
 > - hlen is now signed as sometimes length can be wrong and we can't pick
 > up negative
 > - did not cope with zero length options and caused code to loop. I have
 > found we are implementing option 192 for CCID3 wrong. (added to todo
 > list to fix this up)
 > - Fixed length 1 check for options.
 > - added a bit more code in.
 > 
 > I have attached the difference between our patches and put a
 > comprehensive patch on my DCCP page which means you can just use my patch:
 > http://wand.cs.waikato.ac.nz/~iam4/dccp/index.html
 > 
 > I will be updating the code further to add more features and to meet
 > tcpdump code standards but not sure when I will do this.
 > 
 > Regards,
 > 
 > Ian
 > 
 > Yoshifumi Nishida wrote:
 > > Hi, 
 > > I made an additional patch for this, which supports checksum calculation
 > > and printing extra information of dccp packets, such as options.
 > > You can get this patch from: 
 > >   http://www.jp.nishida.org/dccp/tcpdump-additional-patch 
 > > 
 > > Thanks,
 > > --
 > > Yoshifumi Nishida
 > > nishida at csl.sony.co.jp
 > > 
 > > 
 > > 
 > > From: Ian McDonald <iam4 at cs.waikato.ac.nz>
 > > Subject: Updated DCCP tcpdump patch
 > > Date: Tue, 02 Aug 2005 13:45:48 +1200
 > > Message-ID: <42EED04C.3040703 at cs.waikato.ac.nz>
 > > 
 > >  > Folks,
 > >  > 
 > >  > I have updated the DCCP tcpdump patch of Arnaldo's and it can be
 > >  > downloaded from my DCCP page:
 > >  > http://wand.cs.waikato.ac.nz/~iam4/dccp.html
 > >  > 
 > >  > Change's from Arnaldo's patch:
 > >  >     - made work for 48 bit acknowledge properly
 > >  >     - print ack number out on a DATAACK packet
 > >  >     - ported Arnaldo's patch to latest tcpdump (CVS 2005-7-31)
 > >  >     - merged in Joacim's patch to fix sequence numbers/ack nos
 > >  >     - added dccp.h to HDR section in Makefile.in
 > >  > 
 > >  > I would appreciate any feedback before I submit to tcpdump maintainers.
 > >  > 
 > >  > I wouldn't mind taking this patch further by adding support for CCID,
 > >  > options etc but this is a good start for now...
 > >  > 
 > >  > Regards,
 > >  > 
 > >  > Ian
 > >  > -
 > >  > To unsubscribe from this list: send the line "unsubscribe dccp" in
 > >  > the body of a message to majordomo at vger.kernel.org
 > >  > More majordomo info at  http://vger.kernel.org/majordomo-info.html
 > >  >