[Gen-art] Gen-ART review of draft-daboo-webdav-sync-06
<david.black@emc.com> Wed, 28 December 2011 04:08 UTC
Return-Path: <david.black@emc.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id C752321F84F9; Tue, 27 Dec 2011 20:08:25 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -106.569
X-Spam-Level:
X-Spam-Status: No, score=-106.569 tagged_above=-999 required=5 tests=[AWL=0.030, BAYES_00=-2.599, RCVD_IN_DNSWL_MED=-4, USER_IN_WHITELIST=-100]
Received: from mail.ietf.org ([12.22.58.30]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ivwlPlMwkRkA; Tue, 27 Dec 2011 20:08:25 -0800 (PST)
Received: from mexforward.lss.emc.com (mexforward.lss.emc.com [128.222.32.20]) by ietfa.amsl.com (Postfix) with ESMTP id 0FF4521F84E5; Tue, 27 Dec 2011 20:08:24 -0800 (PST)
Received: from hop04-l1d11-si01.isus.emc.com (HOP04-L1D11-SI01.isus.emc.com [10.254.111.54]) by mexforward.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id pBS489dD010634 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 27 Dec 2011 23:08:14 -0500
Received: from mailhub.lss.emc.com (mailhub.lss.emc.com [10.254.221.253]) by hop04-l1d11-si01.isus.emc.com (RSA Interceptor); Tue, 27 Dec 2011 23:07:53 -0500
Received: from mxhub27.corp.emc.com (mxhub27.corp.emc.com [10.254.110.183]) by mailhub.lss.emc.com (Switch-3.4.3/Switch-3.4.3) with ESMTP id pBS47plW009483; Tue, 27 Dec 2011 23:07:52 -0500
Received: from mx14a.corp.emc.com ([169.254.1.216]) by mxhub27.corp.emc.com ([10.254.110.183]) with mapi; Tue, 27 Dec 2011 23:07:52 -0500
From: david.black@emc.com
To: cyrus@daboo.name, arnaud.quillaud@oracle.com, gen-art@ietf.org, ietf@ietf.org
Date: Tue, 27 Dec 2011 23:07:49 -0500
Thread-Topic: Gen-ART review of draft-daboo-webdav-sync-06
Thread-Index: AczFFkMHKXMAiC0wQuyRMXwEhv6h1A==
Message-ID: <7C4DFCE962635144B8FAE8CA11D0BF1E05A5CC94C9@MX14A.corp.emc.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
acceptlanguage: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-EMM-MHVC: 1
Cc: stpeter@stpeter.im
Subject: [Gen-art] Gen-ART review of draft-daboo-webdav-sync-06
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 28 Dec 2011 04:08:25 -0000
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Please resolve these comments along with any other Last Call comments you may receive. Document: draft-daboo-webdav-sync-06 Reviewer: David L. Black Review Date: December 27, 2011 IETF LC End Date: December 29, 2011 Summary: This draft is on the right track but has open issues, described in the review. This draft specifies new WebDAV functionality that reports on changes to collections, enabling a local copy to be kept in sync without retrieving the entire collection each time. I found three open issues, two major, one minor: [1] -Major- Section 3.5 does not appear to cover the case reporting added elements on a subsequent synchronization. The problem may be that the word "changed" as used in Section 3.5.1 is assumed to cover adding an element - if so, that's not a good assumption, and the addition case should be explicitly called out in the title and body of Section 3.5.1. [2] -Major- The operations to retrieve changed members of a collection are not atomic wrt the operation that obtains a report on what has changed; collection changes can occur between retrieving the report and retrieving the changed elements or while retrieving the changed elements. For this reason, simply obtaining a change report and then retrieving the elements that have changed according to the report may not result in a consistent (e.g., as of a point in time) copy of a collection. I believe that this absence of atomicity is a WebDAV "feature", as opposed to a "bug", but I believe that this behavior and what to do about it should be discussed in the draft. I suggest the following, possibly to the end of section 3.1 i) Add a sentence or two to warn that obtaining a change report and then retrieving the changed elements may not result in a consistent local version of the collection if nothing else is done because changes may have occurred in the interim. ii Add a discussion of how to ensure that a local copy of the collection is consistent. The basic idea is to re-presented the sync token for that copy to the server after the changed elements have been retrieved; the local copy is consistent if the server reports that there have been no changes. Some pseudo-code may help, e.g.: GetSyncCollectionReport(in token, out newtoken, out report); while (ReportHasChangedItems(report) { GetChangedItems(report) token = newtoken; GetSyncCollectionReport(in token, out newtoken, out report); } Actual code should include a counter that counts the number of iterations of the while loop and exits with an error if the number of iterations exceeds some limit; that error exit implies that the collection is (currently) changing too rapidly to obtain a consistent local version. [3] -Minor- idnits 2.12.12 reports a Downref to RFC 5842. Please consult your Area Director (Peter Saint-Andre) to determine what to do about this Downref (it requires attention, but may not require changes to the draft). Nit: I suggest not using the author's own name (cyrusdaboo) in the examples. Someone may copy the code from the resulting RFC. Nit: idnits 2.12.12 reports that draft-ietf-vcarddav-carddav has been published as RFC 6352; the RFC Editor will correct this if a new version of the draft is not required for other reasons. Thanks, --David ---------------------------------------------------- David L. Black, Distinguished Engineer EMC Corporation, 176 South St., Hopkinton, MA 01748 +1 (508) 293-7953 FAX: +1 (508) 293-7786 david.black@emc.com Mobile: +1 (978) 394-7754 ----------------------------------------------------
- [Gen-art] Gen-ART review of draft-daboo-webdav-sy… david.black
- Re: [Gen-art] Gen-ART review of draft-daboo-webda… Cyrus Daboo
- Re: [Gen-art] Gen-ART review of draft-daboo-webda… david.black
- Re: [Gen-art] Gen-ART review of draft-daboo-webda… Peter Saint-Andre
- [Gen-art] Gen-ART review of draft-daboo-webdav-sy… david.black
- Re: [Gen-art] Gen-ART review of draft-daboo-webda… Russ Housley