[Gen-art] Gen-ART LC review of draft-claise-export-application-info-in-ipfix-05

"Roni Even" <ron.even.tlv@gmail.com> Sat, 07 April 2012 09:56 UTC

From: Roni Even <ron.even.tlv@gmail.com>
To: draft-claise-export-application-info-in-ipfix.all@tools.ietf.org
Date: Sat, 07 Apr 2012 12:54:31 +0300
Message-ID: <4f800f2f.634cb40a.13a1.ffff8003@mx.google.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_001F_01CD14BD.951D43F0"
thread-index: Ac0UpG0cMvU2C0UrT7SzRsZNsOhy0w==
Content-Language: en-us
Cc: gen-art@ietf.org, 'IETF' <ietf@ietf.org>
Subject: [Gen-art] Gen-ART LC review of draft-claise-export-application-info-in-ipfix-05
Precedence: list

I am the assigned Gen-ART reviewer for this draft. For background on
Gen-ART, please see the FAQ at
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

 

Please resolve these comments along with any other Last Call comments you
may receive.

 

Document: draft-claise-export-application-info-in-ipfix-05

Reviewer: Roni Even

Review Date:2012-4-7

IETF LC End Date: 2012-4-17

IESG Telechat date:

 

Summary: This draft is almost ready for publication as an Informational RFC.

 

Major issues:

 

Minor issues:

 

1.       In sections 2, 4.1 (PANA-L7), 5, 6.5 the draft points to
information in Cisco web page. I could not locate and information that is
referenced. The link is to the main Cisco web page. For example in section
6.5 it lists the selectorID as 10000, where is this value located?

2.       For the definition of Classification engine IDs in section 4.1 for
the non standard values like PANA-L3, PANA-L4, PANA-L7, PANA-L2, is there a
requirement that the selector IDs will be publically available?

3.       In section 4.2 "However, an IANA L3 protocol encoding may encoded
with 3 bytes." When is it encoded in 3 bytes, also figure 2 is not
reflecting this example, I expected to see a 32 bit value according to the
text and not a general figure. (small nit in the above sentence "may be"
instead of "may".

4.       In section 7 I noticed that "p2pTechnology, tunnelTechnology, and
encryptedTechnology" are already assigned in the IANA IPFIX Information
elements so why assign them again as new?

5.       In section 7 I noticed that you request that the
applicationDescription, applicationId, applicationName,
classificationEngineId will receive elementid values from the range 0-127.
My reading from section 4.2 is this is not required, maybe add text that
will explain this request.

6.       In the security section are there additional considerations when
the applicationid information is coming from a proprietary classification
engine about authentication of the information source?

 

Nits/editorial comments:

 

1.       In section 4.1 last sentence what is the meaning of "by theses
specifications" , I did not understand the context.

2.       In section 6.6 "to determine whether or the default HTTP port"
delete the "or"

3.       In section 6.6 "The Classification Engine ID is 2" should be "3".

[Gen-art] Gen-ART LC review of draft-claise-expor… Roni Even
Re: [Gen-art] Gen-ART LC review of draft-claise-e… Benoit Claise
Re: [Gen-art] Gen-ART LC review of draft-claise-e… Roni Even
Re: [Gen-art] Gen-ART LC review of draft-claise-e… Benoit Claise
Re: [Gen-art] Gen-ART LC review of draft-claise-e… Roni Even
Re: [Gen-art] Gen-ART LC review of draft-claise-e… Russ Housley