[Gen-art] Gen-art telechat review of draft-ietf-json-rfc4627bis-09.txt
Elwyn Davies <elwynd@folly.org.uk> Tue, 17 December 2013 13:24 UTC
Return-Path: <elwynd@folly.org.uk>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 457A11ADF92 for <gen-art@ietfa.amsl.com>; Tue, 17 Dec 2013 05:24:03 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.9
X-Spam-Level:
X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xAL0uHZh3TnO for <gen-art@ietfa.amsl.com>; Tue, 17 Dec 2013 05:24:00 -0800 (PST)
Received: from bounce.a.painless.aa.net.uk (a.painless.aa.net.uk [IPv6:2001:8b0:0:30::51bb:1e33]) by ietfa.amsl.com (Postfix) with ESMTP id 7998E1AE0B9 for <gen-art@ietf.org>; Tue, 17 Dec 2013 05:24:00 -0800 (PST)
Received: from mightyatom.folly.org.uk ([81.187.254.250]) by a.painless.aa.net.uk with esmtp (Exim 4.77) (envelope-from <elwynd@folly.org.uk>) id 1Vsucu-0006XT-V5; Tue, 17 Dec 2013 13:23:57 +0000
From: Elwyn Davies <elwynd@folly.org.uk>
To: General Area Review Team <gen-art@ietf.org>
Content-Type: text/plain
Organization: Folly Consulting
Date: Tue, 17 Dec 2013 13:23:55 +0000
Message-Id: <1387286635.24761.188.camel@mightyatom>
Mime-Version: 1.0
X-Mailer: Evolution 2.26.3
Content-Transfer-Encoding: 7bit
Cc: draft-ietf-json-rfc4627bis.all@tools.ietf.org
Subject: [Gen-art] Gen-art telechat review of draft-ietf-json-rfc4627bis-09.txt
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 17 Dec 2013 13:24:03 -0000
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at < http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Please wait for direction from your document shepherd or AD before posting a new version of the draft. Document: draft-ietf-json-rfc4627bis-09.txt Reviewer: Elwyn Davies Review Date: 17 December 2013 IETF LC End Date: 25 November 2013 IESG Telechat date: 19 December 2013 Summary: Almost ready for publication as a standard track RFC. Several of the issues identified in the last call/previous telechat review have been addressed but the authors have noted that the document update was agreed on the basis that it would make minimal changes. However, at least the first of the 'minor issues' called out represents undocumented functionality that could result in non-interoperable implemenattions if the unordered requirement is not honoured. The second is an inconsistency and the third is a judgment call. There are a couple of recommendations that I think would assist readability and reflect usual practice with such documents. Major issues: None. Minor issues: s4: The unordered nature of the entries in an object is not mentioned. Presumably it should state that two objects with the same sets of name-value pairs ("members") in any order are logically equivalent. s10: s9 allows there to be parsers that accept extensions. s10 only allows generators to produce strict JSON. Perhaps one should allow for strict generators and extended generators that match with extended parsers? s12: Since JSON text may potentially be parsed (effectively compiled) into what looks like a piece of executable binary, it is vital that parsers don't suffer from buffer overruns etc. This should probably be called out. Nits/editorial comments: General: Many RFCs that use ABNF specifications where parts of the ABNF are presented in separate sections also provide a section or appendix with the whole of the ABNF in one place. Whilst this provides a very minor double maintenance problem, it does aid implementers and facilitates checking of the complete grammar to catch mismatches. s6: To be absolutely definite, assert that numbers are represented in base 10. s13: Might be useful to insert examples with - an array with elements that are not the same type - equivalent objects with the members in different orders. These could also show off escape sequences and maximally compact formats (using the equivalent object example to show that the white space is irrelevant). _______________________________________________ Gen-art mailing list Gen-art@ietf.org https://www.ietf.org/mailman/listinfo/gen-art
- [Gen-art] Gen-art telechat review of draft-ietf-j… Elwyn Davies
- Re: [Gen-art] Gen-art telechat review of draft-ie… Jari Arkko
- Re: [Gen-art] Gen-art telechat review of draft-ie… Tim Bray
- Re: [Gen-art] Gen-art telechat review of draft-ie… Paul Hoffman
- Re: [Gen-art] Gen-art telechat review of draft-ie… Elwyn Davies
- Re: [Gen-art] Gen-art telechat review of draft-ie… Paul Hoffman
- Re: [Gen-art] Gen-art telechat review of draft-ie… Elwyn Davies
- Re: [Gen-art] Gen-art telechat review of draft-ie… Paul Hoffman
- Re: [Gen-art] Gen-art telechat review of draft-ie… Elwyn Davies
- Re: [Gen-art] Gen-art telechat review of draft-ie… Paul Hoffman
- Re: [Gen-art] Gen-art telechat review of draft-ie… Elwyn Davies
- Re: [Gen-art] Gen-art telechat review of draft-ie… Paul Hoffman
- Re: [Gen-art] Gen-art telechat review of draft-ie… Jari Arkko
- Re: [Gen-art] Gen-art telechat review of draft-ie… Tim Bray
- Re: [Gen-art] Gen-art telechat review of draft-ie… Paul Hoffman
- Re: [Gen-art] Gen-art telechat review of draft-ie… Tim Bray
- Re: [Gen-art] Gen-art telechat review of draft-ie… Jari Arkko
- Re: [Gen-art] Gen-art telechat review of draft-ie… Elwyn Davies