[Gen-art] Gen-ART review of draft-ietf-isis-rfc6326bis-01

Alexey Melnikov <alexey.melnikov@isode.com> Mon, 20 January 2014 11:12 UTC

Return-Path: <alexey.melnikov@isode.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D61A91A011B for <gen-art@ietfa.amsl.com>; Mon, 20 Jan 2014 03:12:49 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.536
X-Spam-Level:
X-Spam-Status: No, score=-2.536 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RP_MATCHES_RCVD=-0.535, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q4SO3gyzpFWp for <gen-art@ietfa.amsl.com>; Mon, 20 Jan 2014 03:12:47 -0800 (PST)
Received: from statler.isode.com (statler.isode.com [62.3.217.254]) by ietfa.amsl.com (Postfix) with ESMTP id BD9F71A0118 for <gen-art@ietf.org>; Mon, 20 Jan 2014 03:12:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1390216367; d=isode.com; s=selector; i=@isode.com; bh=zcLlROWNU+o0UdchuL8YjTEYkGESgc1d3md62s/Pt0Y=; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version: In-Reply-To:References:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description; b=JjC8kMKMGIuWv0P28hY66qo5gkeucrXsWJWD6PhnFi25/NwiAhYudU+Ru6THlL4LH3AkjI w5t4IHaIy288sGETPlIozwrEfEYoNFsWxNcdkW70lB45HpY4fPXEj4aJ96YUp3izM0RLRN hZc0go9Gksm9NmIGZJeW0Ok7V8rpMjE=;
Received: from [172.17.128.75] (richard.isode.com [62.3.217.249]) by statler.isode.com (submission channel) via TCP with ESMTPSA id <Ut0ErgBvgYWd@statler.isode.com>; Mon, 20 Jan 2014 11:12:47 +0000
X-SMTP-Protocol-Errors: PIPELINING
Message-ID: <52DD04AE.8070604@isode.com>
Date: Mon, 20 Jan 2014 11:12:46 +0000
From: Alexey Melnikov <alexey.melnikov@isode.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7
To: draft-ietf-isis-rfc6326bis.all@tools.ietf.org
MIME-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format="flowed"
Content-Transfer-Encoding: 7bit
Cc: gen-art@ietf.org
Subject: [Gen-art] Gen-ART review of draft-ietf-isis-rfc6326bis-01
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Jan 2014 11:12:50 -0000

I am the assigned Gen-ART reviewer for this draft. For background on 
Gen-ART, please see the FAQ at 
<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Please resolve these comments along with any other Last Call comments 
you may receive.

Document: draft-ietf-isis-rfc6326bis-01
Reviewer: Alexey Melnikov
Review Date: 2014-01-20
IETF LC End Date: 2014-01-22
IESG Telechat date: 2014-01-23


Summary: This draft is nearly ready for publication as a standard track RFC.

Major issues: None

Minor issues:

o  Label: This carries the fine-grained label identifier for all
       subsequent MAC addresses in this sub-TLV, or the value zero if no
       label is specified.


I fully admit ignorance of the topic, but what is exactly "fine-grained 
label" and where is the exact format defined? If it is defined later in 
the document, can you please add a forward reference. If it is defined 
in another document, can you please add a reference to that.


In Sections 2.2.4 and 2.3.1:

What are the requirements on backward compatibility between different 
versions of TRILL. Are TLVs formats supported for a version N also valid 
for version N+M? If you have any implied assumptions, please state them 
in the document.



Nits/editorial comments: None