IETF Logo Mail Archive

[Gen-art] Gen-ART review of draft-ietf-ppsp-peer-protocol-10

Christer Holmberg <christer.holmberg@ericsson.com> Mon, 30 June 2014 10:07 UTC

Return-Path: <christer.holmberg@ericsson.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id D533C1A01D9 for <gen-art@ietfa.amsl.com>; Mon, 30 Jun 2014 03:07:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.901
X-Spam-Level:
X-Spam-Status: No, score=-1.901 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OVv7dnpw9LJU for <gen-art@ietfa.amsl.com>; Mon, 30 Jun 2014 03:07:19 -0700 (PDT)
Received: from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 020C91A01C8 for <gen-art@ietf.org>; Mon, 30 Jun 2014 03:07:18 -0700 (PDT)
X-AuditID: c1b4fb3a-f799e6d000005085-e8-53b136d49d54
Received: from ESESSHC013.ericsson.se (Unknown_Domain [153.88.253.124]) by sessmg22.ericsson.net (Symantec Mail Security) with SMTP id E9.52.20613.4D631B35; Mon, 30 Jun 2014 12:07:17 +0200 (CEST)
Received: from ESESSMB209.ericsson.se ([169.254.9.4]) by ESESSHC013.ericsson.se ([153.88.183.57]) with mapi id 14.03.0174.001; Mon, 30 Jun 2014 12:07:16 +0200
From: Christer Holmberg <christer.holmberg@ericsson.com>
To: "gen-art@ietf.org" <gen-art@ietf.org>
Thread-Topic: Gen-ART review of draft-ietf-ppsp-peer-protocol-10
Thread-Index: AQHPlEp/LVmkB6g39Ema5CB9sZrALw==
Date: Mon, 30 Jun 2014 10:07:15 +0000
Message-ID: <7594FB04B1934943A5C02806D1A2204B1D3AB180@ESESSMB209.ericsson.se>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-originating-ip: [153.88.183.19]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKLMWRmVeSWpSXmKPExsUyM+Jvje5Vs43BBgvbmS3Or7zBanH11WcW ByaPJUt+Mnl8ufyZLYApissmJTUnsyy1SN8ugStj29WvTAWreSpeXf3M3sD4n6OLkZNDQsBE ov3CIhYIW0ziwr31bF2MXBxCAkcZJT7f3sIE4SxiBKr6DuRwcLAJWEh0/9MGaRAR0JSYu+It E4jNLJAtceXcfjBbWMBaYtL9Z0wQNQ4SW27eZoSw9SSO9LUwg9gsAqoSdy51soLYvAK+Eh29 78FqGIGO+H5qDdRMcYlbT+YzQRwnILFkz3lmCFtU4uXjf6wQtqJE+9MGRoh6HYkFuz+xQdja EssWvmaGmC8ocXLmE5YJjCKzkIydhaRlFpKWWUhaFjCyrGIULU4tLs5NNzLSSy3KTC4uzs/T y0st2cQIjIeDW35b7WA8+NzxEKMAB6MSD++CIxuChVgTy4orcw8xSnOwKInzLjw3L1hIID2x JDU7NbUgtSi+qDQntfgQIxMHp1QD47wFPbeqrm/Zria+KG75whuCJsZXNoXe2vMnrrI6c0u+ /D3ufocKjue5j53WMveIdIawBtsd0mk7qxzzK2Xj5CvF+152PWw5FB70pNOrbEWBdful3UXf sitezrzY4P9ZfNrfudOvy1zu7s70a17Z47lU2n7xmcRtm3uOci5WsjTofL4z9PrlUCWW4oxE Qy3mouJEAJHzxVpoAgAA
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/meWcpxDQ-6MIUSNz7wy1vC-RMq8
Cc: "draft-ietf-ppsp-peer-protocol.all@tools.ietf.org" <draft-ietf-ppsp-peer-protocol.all@tools.ietf.org>
Subject: [Gen-art] Gen-ART review of draft-ietf-ppsp-peer-protocol-10
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 30 Jun 2014 10:07:21 -0000

I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>

Document:                         draft-ietf-ppsp-peer-protocol-10

Reviewer:                           Christer Holmberg

Review Date:                     30 June 2014

IETF LC End Date:             1 July 2014

IETF Telechat Date:         10 July 2014

Summary:                         The document is well written, and almost ready for publication. However, there is a minor issue which I ask the authors to address.

Major Issues: None

Minor Issues:

Section 3.12 talks about keep alive signaling.

Q1: The sending of keep alives is a SHOULD, and there are no procedures on how to act if keep alives are not received. There isn't even a mechanism to negotiate the sending of keep alives. 

So, I assume it means that a peer shall not take any actions if it does NOT receive keep alives, or even rely on receiving keep alives to begin with? If so, I think it would be good to clarify that.

Q2: As the sending of keep alives is a SHOULD, are there example cases when keep alives would NOT be sent?

Q3: The text saying "to each peer it wants to interact with in the future" sounds a little strange to me. How does a peer know with whom it wants to interact in the future? Perhaps the text instead should talk about peers with whom one wants to maintain a signaling channel, or something like that?


Editorial nits: None


Regards,

Christer

v2.23.0 | Report a Bug | By Email