[Gen-art] Gen-ART review of draft-ietf-ospf-te-metric-extensions-09
Martin Thomson <martin.thomson@gmail.com> Mon, 29 December 2014 20:13 UTC
Return-Path: <martin.thomson@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B559C1AC3E5 for <gen-art@ietfa.amsl.com>; Mon, 29 Dec 2014 12:13:38 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bN2dJApXIIUx for <gen-art@ietfa.amsl.com>; Mon, 29 Dec 2014 12:13:35 -0800 (PST)
Received: from mail-ob0-x22a.google.com (mail-ob0-x22a.google.com [IPv6:2607:f8b0:4003:c01::22a]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id DD2241AC3EA for <gen-art@ietf.org>; Mon, 29 Dec 2014 12:13:34 -0800 (PST)
Received: by mail-ob0-f170.google.com with SMTP id wp18so42495189obc.1 for <gen-art@ietf.org>; Mon, 29 Dec 2014 12:13:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=CjiAMqaYkVom795xzmQDQH5+xp1Zi+fUREZAOfqe8tQ=; b=r+oB8TO0GWcGfoOpMKQuFF3gAqIzeqfQMnIh17hCEJUJa3mnlxAQCVdpe5wpNUc8ub PFfqtyk2pby4B8RtoyEIz+1dTbjOpkoZORuRA0RtoI4gC6K+YwMMkoN3tDV9PxVjAPv8 5KCKnwGMHbDVELwzciW/ps2WVl0v6KFfQxOee1gUnnmgKdGotakWHkgWK4A6LwSTnLWi fdAUrjXRygJRciyzdp+XJdwWv/xlkJdVr9itOsZrwMiGxTVaVLSaN1wYTywYP5HgVmuU Pbrg4JkEDxrKc12bzizJCrWjS2OrSMFKFG1YAzjUTQHFNRODtv5HLbafc/+OFjzmlWuU HJPA==
MIME-Version: 1.0
X-Received: by 10.60.131.232 with SMTP id op8mr32439955oeb.59.1419884014265; Mon, 29 Dec 2014 12:13:34 -0800 (PST)
Received: by 10.202.49.203 with HTTP; Mon, 29 Dec 2014 12:13:34 -0800 (PST)
Date: Mon, 29 Dec 2014 12:13:34 -0800
Message-ID: <CABkgnnVd0_WjgAcgJQ1R2Da=zLL1XnOV9mHmP5-dyQ3zoJ7wvA@mail.gmail.com>
From: Martin Thomson <martin.thomson@gmail.com>
To: "gen-art@ietf.org" <gen-art@ietf.org>, draft-ietf-ospf-te-metric-extensions.all@tools.ietf.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: http://mailarchive.ietf.org/arch/msg/gen-art/m0jHZnZbFxJ1OZSMP1X-Rzim6YM
Subject: [Gen-art] Gen-ART review of draft-ietf-ospf-te-metric-extensions-09
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Dec 2014 20:13:38 -0000
I am the assigned Gen-ART reviewer for this draft. For background on Gen-ART, please see the FAQ at < http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Please wait for direction from your document shepherd or AD before posting a new version of the draft. Document: draft-ietf-ospf-te-metric-extensions-09 Reviewer: Martin Thomson Review Date: 2014-12-29 IETF LC End Date: 2014-12-24 (nice) IESG Telechat date: 2015-01-08 Summary: Good for PS with some minor issues. Observations: I find it a little disappointing that measurement techniques are so nebulously defined. Values are measured over "a period" using "some method, which might be RFC 6374". The "A" bit threshold is "a configured value". That means that a consumer of this information has to take a lot on faith. I have to assume that this is because we can't do better. Minor issues: Please ensure that all the field descriptions include some textual indication of the size of the field. Type and length are always 16 bits each, so those can be assumed from RFC 3630. As above, please specify the specific IEEE 754 floating point format, i.e., "single precision". Otherwise you have to look at the figures to work out how many bits to use for the value and figures should be strictly informational. Nits: Section 10 is missing a period.
- [Gen-art] Gen-ART review of draft-ietf-ospf-te-me… Martin Thomson
- Re: [Gen-art] Gen-ART review of draft-ietf-ospf-t… Jari Arkko
- Re: [Gen-art] Gen-ART review of draft-ietf-ospf-t… Acee Lindem (acee)