[Gen-art] Gen-art LC review of draft-ietf-nfsv4-minorversion2-dot-x-39
Elwyn Davies <elwynd@dial.pipex.com> Mon, 14 December 2015 00:44 UTC
Return-Path: <elwynd@dial.pipex.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id 62EAB1A8AA6; Sun, 13 Dec 2015 16:44:18 -0800 (PST)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -101.9
X-Spam-Level:
X-Spam-Status: No, score=-101.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, USER_IN_WHITELIST=-100] autolearn=ham
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Jax4f_uZdtjL; Sun, 13 Dec 2015 16:44:15 -0800 (PST)
Received: from auth.a.painless.aa.net.uk (a.painless.aa.net.uk [IPv6:2001:8b0:0:30::51bb:1e33]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 90BC61A8A9B; Sun, 13 Dec 2015 16:44:15 -0800 (PST)
Received: from 7.c.e.0.e.5.2.4.1.d.5.0.a.e.4.4.1.0.0.0.f.b.0.0.0.b.8.0.1.0.0.2.ip6.arpa ([2001:8b0:bf:1:44ea:5d1:425e:ec7]) by a.painless.aa.net.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.77) (envelope-from <elwynd@dial.pipex.com>) id 1a8HFK-0004eu-N9; Mon, 14 Dec 2015 00:44:13 +0000
To: General area reviewing team <gen-art@ietf.org>
From: Elwyn Davies <elwynd@dial.pipex.com>
Message-ID: <566E10D8.3040002@dial.pipex.com>
Date: Mon, 14 Dec 2015 00:44:08 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 7bit
Archived-At: <http://mailarchive.ietf.org/arch/msg/gen-art/iHj0kXbXQgZ5N1p2wSKcdinHKtk>
Cc: draft-ietf-nfsv4-minorversion2-dot-x.all@ietf.org
Subject: [Gen-art] Gen-art LC review of draft-ietf-nfsv4-minorversion2-dot-x-39
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Mon, 14 Dec 2015 00:44:18 -0000
I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For more information, please see the FAQ at <http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>. Document: draft-ietf-nfsv4-minorversion2-dot-x-39.txt Reviewer: Elwyn Davies Review Date: 2015-12-13 IETF LC End Date: 2015-12-09 IESG Telechat date: (if known) - Summary: Ready with nits. The XDR specification appears to be a superset of the v4.1 XDR specification and combines a correction of the five remaining discrepancies between v4.1 and v4.0bis ( definition and use of the NFS4_OTHER_SIZE constant, addition and use of the ascii_REQUIRED4 type, modification of the typedef of linktext4). The additions of the 4.2 interface appears to match the specification in draft-ietf-nfsv4-minorversion2-39 except for two attribute typedef items mentioned below. One discrepancy would have no operational effect as the type used in the other draft is an alias for the type used here but the clone_blksize error changes the size of the type. I have checked that the extracted code is accepted by rpcgen and generates files as expected. Major issues: None Minor issues: None Nits/editorial comments: Observation: It might be useful to note that this XDR specification is fully upwards compatible with the v4.0bis with the minor exception of the clientaddr4 structure which has been replaced by (strictly, aliased to) netaddr4 which has the same members with the same purposes but the names have changed (r_netid -> na_r_netid, r_addr ->na_r_addr). This effectively fully reconverges the v4.0bis and v4.1 strands of the XDR. Line 1145: In draft-ietf-nfsv4-minorversion2-39 we have typedef length4 fattr4_space_freed whereas in this draft we have typedef uint64_t fattr4_space_freed Line 1149: In draft-ietf-nfsv4-minorversion2-39 we have typedef length4 fattr4_clone_blksize whereas in this draft we have typedef uint32_t fattr4_clone_blksize
- [Gen-art] Gen-art LC review of draft-ietf-nfsv4-m… Elwyn Davies
- Re: [Gen-art] Gen-art LC review of draft-ietf-nfs… Tom Haynes
- Re: [Gen-art] Gen-art LC review of draft-ietf-nfs… Elwyn Davies
- Re: [Gen-art] Gen-art LC review of draft-ietf-nfs… Tom Haynes
- Re: [Gen-art] Gen-art LC review of draft-ietf-nfs… Elwyn Davies
- Re: [Gen-art] Gen-art LC review of draft-ietf-nfs… Thomas Haynes
- Re: [Gen-art] Gen-art LC review of draft-ietf-nfs… Jari Arkko