Re: Gen-ART LC Review of draft-freed-sieve-date-index-11

[Ben Campbell <ben at estacado.net>]

Hi,

Your response resolves all of my comments. Details inline.

Thanks!

Ben.

On May 24, 2008, at 7:08 PM, Ned Freed wrote:

>> I have been selected as the General Area Review Team (Gen-ART)
>> reviewer for this draft (for background on Gen-ART, please see
>> http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html).
>
>> Please resolve these comments along with any other Last Call comments
>> you may receive.
>
>> Document: draft-freed-sieve-date-index-11
>> Reviewer: Ben Campbell
>> Review Date:  2008-05-23
>> IETF LC End Date: 2008-05-28
>> IESG Telechat date: (if known)
>
>> Summary:
>
>> This document is basically ready for publication as a draft standard.
>> I have a few minor comments which I consider optional to address.
>
>> Comments:
>
>> Section 4:
>
>> Does it make sense to add a reference for ":is" and "i;ascii- 
>> casemap"?
>
> No. These are both core Sieve items defined in the Sieve base  
> specification.
> Anyone with enough familiarity with Sieve to actually make use of this
> specification either as an implementor or user will necessarily know  
> what these
> are.

Okay

>
>
>> Can you mention the reason that the date test can only apply to one
>> header field at a time?
>
> Date-time values specify a point in time. When you test one you're  
> looking to
> see if it meets certain criteria: Before a given time, after a given  
> time, or
> within some interval. The results bFrom ietf-bounces at ietf.org  Sun May 25 11:12:29 2008
Return-Path: <ietf-bounces at ietf.org>
X-Original-To: ietf-archive at megatron.ietf.org
Delivered-To: ietfarch-ietf-archive at core3.amsl.com
Received: from [127.0.0.1] (localhost [127.0.0.1])
	by core3.amsl.com (Postfix) with ESMTP id 92A603A6B8C;
	Sun, 25 May 2008 11:12:29 -0700 (PDT)
X-Original-To: ietf at core3.amsl.com
Delivered-To: ietf at core3.amsl.com
Received: from localhost (localhost [127.0.0.1])
	by core3.amsl.com (Postfix) with ESMTP id B78A83A6B38;
	Sun, 25 May 2008 11:10:20 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2.247
X-Spam-Level: 
X-Spam-Status: No, score=-2.247 tagged_above=-999 required=5 tests=[AWL=0.352, 
	BAYES_00=-2.599]
Received: from mail.ietf.org ([64.170.98.32])
	by localhost (core3.amsl.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 28Puo-RE8iGV; Sun, 25 May 2008 11:10:19 -0700 (PDT)
Received: from estacado.net (estacado-pt.tunnel.tserv2.fmt.ipv6.he.net
	[IPv6:2001:470:1f03:266::2])
	by core3.amsl.com (Postfix) with ESMTP id 3C98D3A6B12;
	Sun, 25 May 2008 11:10:19 -0700 (PDT)
Received: from [10.0.1.197] (adsl-68-94-3-108.dsl.rcsntx.swbell.net
	[68.94.3.108]) (authenticated bits=0)
	by estacado.net (8.14.2/8.14.1) with ESMTP id m4PIA6QK009412
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Sun, 25 May 2008 13:10:11 -0500 (CDT)
	(envelope-from ben at estacado.net)
Message-Id: <6FB448DD-B959-432E-9804-FC3133E00F35 at estacado.net>
From: Ben Campbell <ben at estacado.net>
To: Ned Freed <ned.freed at mrochek.com>
In-Reply-To: <01MV6BC5XFXK00007A at mauve.mrochek.com>
Mime-Version: 1.0 (Apple Message framework v919.2)
Subject: Re: Gen-ART LC Review of draft-freed-sieve-date-index-11
Date: Sun, 25 May 2008 13:10:15 -0500
References: <09AD9420-BE70-40DB-ADB9-74C7C79470A4 at estacado.net>
	<01MV6BC5XFXK00007A at mauve.mrochek.com>
X-Mailer: Apple Mail (2.919.2)
Cc: cyrus at daboo.name, alexey.melnikov at isode.com,
	General Area Review Team <gen-art at ietf.org>,
	Lisa Dusseault <lisa at osafoundation.org>, ietf at ietf.org
X-BeenThere: ietf at ietf.org
X-Mailman-Version: 2.1.9
Precedence: list
List-Id: IETF Discussion <ietf.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/listinfo/ietf>,
	<mailto:ietf-request at ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/pipermail/ietf>
List-Post: <mailto:ietf at ietf.org>
List-Help: <mailto:ietf-request at ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/ietf>,
	<mailto:ietf-request at ietf.org?subject=subscribe>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Sender: ietf-bounces at ietf.org
Errors-To: ietf-bounces at ietf.org

Hi,

Your response resolves all of my comments. Details inline.

Thanks!

Ben.

On May 24, 2008, at 7:08 PM, Ned Freed wrote:

>> I have been selected as the General Area Review Team (Gen-ART)
>> reviewer for this draft (for background on Gen-ART, please see
>> http://www.alvestrand.no/ietf/gen/art/gen-art-FAQ.html).
>
>> Please resolve these comments along with any other Last Call comments
>> you may receive.
>
>> Document: draft-freed-sieve-date-index-11
>> Reviewer: Ben Campbell
>> Review Date:  2008-05-23
>> IETF LC End Date: 2008-05-28
>> IESG Telechat date: (if known)
>
>> Summary:
>
>> This document is basically ready for publication as a draft standard.
>> I have a few minor comments which I consider optional to address.
>
>> Comments:
>
>> Section 4:
>
>> Does it make sense to add a reference for ":is" and "i;ascii- 
>> casemap"?
>
> No. These are both core Sieve items defined in the Sieve base  
> specification.
> Anyone with enough familiarity with Sieve to actually make use of this
> specification either as an implementor or user will necessarily know  
> what these
> are.

Okay

>
>
>> Can you mention the reason that the date test can only apply to one
>> header field at a time?
>
> Date-time values specify a point in time. When you test one you're  
> looking to
> see if it meets certain criteria: Before a given time, after a given  
> time, or
> within some interval. The results become amecome ambiguous the minute you  
> allow the
> test to consider multiple dates - someimtes you'd want it to succeed  
> only if
> all the dates passed the test, other times if any passed - so the  
> test is
> constructed so only a single date is selected.
>
> I'm a long way from convinced such a longwinded explanation is worth  
> adding,
> however. Instead I'll just put in a point about this limit keeping  
> the meaning
> of the test simple and obvious.
>

I think that's good enough, thanks.

>> Last paragraph, last sentence: "... the last one that appears should
>> be used."
>
>> Is that a normative SHOULD?
>
> Sure, why not?
>
>> Section 4.1, time-zone syntax:
>
>> I assume the 4 digits are hhmm, as mentioned later in the discussion
>> of default time zone. It might help to explicitly state that in this
>> section.
>
> AFAIK there is no zone offset defined anywhere in email that works  
> any other
> way, but adding an explanation of it can't hurt.
>
>> Section 6.1, section title:
>
>> Section title is "Examples", but I only see one example :-)
>
> Fixed.
>
> 				Ned

_______________________________________________
IETF mailing list
IETF at ietf.org
https://www.ietf.org/mailman/listinfo/ietf


biguous the minute you  
> allow the
> test to consider multiple dates - someimtes you'd want it to succeed  
> only if
> all the dates passed the test, other times if any passed - so the  
> test is
> constructed so only a single date is selected.
>
> I'm a long way from convinced such a longwinded explanation is worth  
> adding,
> however. Instead I'll just put in a point about this limit keeping  
> the meaning
> of the test simple and obvious.
>

I think that's good enough, thanks.

>> Last paragraph, last sentence: "... the last one that appears should
>> be used."
>
>> Is that a normative SHOULD?
>
> Sure, why not?
>
>> Section 4.1, time-zone syntax:
>
>> I assume the 4 digits are hhmm, as mentioned later in the discussion
>> of default time zone. It might help to explicitly state that in this
>> section.
>
> AFAIK there is no zone offset defined anywhere in email that works  
> any other
> way, but adding an explanation of it can't hurt.
>
>> Section 6.1, section title:
>
>> Section title is "Examples", but I only see one example :-)
>
> Fixed.
>
> 				Ned

_______________________________________________
IETF mailing list
IETF at ietf.org
https://www.ietf.org/mailman/listinfo/ietf