[MMUSIC] my review of draft-ietf-mmusic-data-channel-sdpneg-02

"Roni Even" <ron.even.tlv@gmail.com> Wed, 03 June 2015 10:29 UTC

Return-Path: <ron.even.tlv@gmail.com>
X-Original-To: mmusic@ietfa.amsl.com
Delivered-To: mmusic@ietfa.amsl.com
Received: from localhost (ietfa.amsl.com [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id A3FA61A0334 for <mmusic@ietfa.amsl.com>; Wed, 3 Jun 2015 03:29:14 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -1.229
X-Spam-Level:
X-Spam-Status: No, score=-1.229 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_SORBS_WEB=0.77, SPF_PASS=-0.001] autolearn=no
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kAm-5JTPqrLO for <mmusic@ietfa.amsl.com>; Wed, 3 Jun 2015 03:29:12 -0700 (PDT)
Received: from mail-wg0-x232.google.com (mail-wg0-x232.google.com [IPv6:2a00:1450:400c:c00::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 072EA1A0273 for <mmusic@ietf.org>; Wed, 3 Jun 2015 03:29:12 -0700 (PDT)
Received: by wgv5 with SMTP id 5so5248522wgv.1 for <mmusic@ietf.org>; Wed, 03 Jun 2015 03:29:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type :thread-index:content-language; bh=RkaUv5rF/0pM/+vGsIh3BWXFM+jKNbFJrmFGsb4FFNw=; b=F7qSyge2Jz14DFm0+47vZdnyLtCc8ibUpemZ/+leJhaN8kXfjvjIeTZ8ZgV0btv9MH SYz/sQIrRd5amlfKUb6w8kpg4yKuc54DQ/pBZSSnHPGK1M8i+8y7e9pMSpDkb88GOzry y8XYOyKRWwY7o2ZuhS1r/5FWqQDvJTlGzX5WYSqJVf+c40zSAjLe5ldM5+DeTvOgxbnD l1Q88TYyxx+7MEs+Au0rJXg1eqhujufY4YS6CCHQrEdcU4j17MJLB2dLsMrQPdjnp+1w 1yYcQ0+xr/+8eXkA+ikaMQJDKbTO3ZOSQd9s4adW01mBhNFDmqP7AfuI0Q5WCARrpnAV 0PRA==
X-Received: by 10.194.178.201 with SMTP id da9mr50585958wjc.139.1433327350765; Wed, 03 Jun 2015 03:29:10 -0700 (PDT)
Received: from RoniE (bzq-79-179-120-74.red.bezeqint.net. [79.179.120.74]) by mx.google.com with ESMTPSA id g11sm406380wjr.25.2015.06.03.03.29.09 for <mmusic@ietf.org> (version=TLSv1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Jun 2015 03:29:10 -0700 (PDT)
From: Roni Even <ron.even.tlv@gmail.com>
To: mmusic@ietf.org
Date: Wed, 03 Jun 2015 13:29:03 +0300
Message-ID: <097101d09de8$1e5e1480$5b1a3d80$@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="----=_NextPart_000_0972_01D09E01.43AC5DF0"
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AdCd6AGWur5DbDLwSW+JenuWTeonWw==
Content-Language: en-us
Archived-At: <http://mailarchive.ietf.org/arch/msg/mmusic/IWNFGvYqH8fgGFs6T7TQTOnXGTU>
Subject: [MMUSIC] my review of draft-ietf-mmusic-data-channel-sdpneg-02
X-BeenThere: mmusic@ietf.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: Multiparty Multimedia Session Control Working Group <mmusic.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/mmusic>, <mailto:mmusic-request@ietf.org?subject=unsubscribe>
List-Archive: <http://www.ietf.org/mail-archive/web/mmusic/>
List-Post: <mailto:mmusic@ietf.org>
List-Help: <mailto:mmusic-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/mmusic>, <mailto:mmusic-request@ietf.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jun 2015 10:29:14 -0000

 

 

Hi,

I read the documents and have some comments

 

1.       The abstract says "This document specifies how the SDP offer/answer
exchange can be used to achieve such an external negotiation." While the
introduction says "This document defines SDP-based out-of-band negotiation
procedures to establish data channels for transport of well-defined
sub-protocols"  I noticed that the document is about using SDP offer answer
and not about any other "out-of-band" negotiation.

2.       In the terminology why do you need both internal and in-band
negotiation and external and out-of-band suggest using one term throughout
the document. I think that using internal or  even better DCEP for in-band
and using external or SDP offer/answer in the document will be better.

3.       I am not sure that the following paragraph is needed "It is also
worth noting that a data channel stack implementation may  not provide any
API to create and close data channels; instead the  data channels are used
on the fly as needed just by communicating via  external means or by even
having some local configuration/assumptions   on both the peers." Why need
API discussion in the document?

4.       Same for "Browser based applications (could include hybrid apps)
will use [WebRtcAPI], while   native applications use a compatible API,
which is yet to be specified"  Why mention external API, this is not
required for the negotiation using SDP offer/answer

5.       In 5.2.3 need to expand SSN.

6.       In 5.2.3 "Depending upon the method used for external negotiation"
are there multiple ones? 

7.       In section 6.2.1 "However, a single stream is managed using one
method at a time." Suggest "MUST be managed"

8.       In section  6.2.2 "By definition max-retr and max-time are mutually
exclusive, so only one  of them can be present in a=dcmap." Suggest MUST be
present.

9.       In section 6.2.3 "If a peer  receives an SDP offer before getting
to send a new SDP " I assume you meant "before starting to send"

10.   The IANA section does not mention the new SDP attributes

Thanks

Roni Even