[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[rohc] TCP profile FN, ip_id_behavior_enc



Hi All,

The current tcp-pf.txt contains the following:

ip_id_behavior_enc ===
{
        uc_format = ip_id_behavior; %[ 2 ]

        default_methods =
        {
          ip_id_behavior ::= irregular(2);
        };

        co_format_sequential = ip_id_behavior, %[ 2 ]
        {
          let (ip_id_behavior:uncomp_value == 0b00);
        };

        co_format_sequential_swapped = ip_id_behavior, %[ 2 ]
        {
          let (ip_id_behavior:uncomp_value == 0b01);
        };

        co_format_random = ip_id_behavior, %[ 2 ]
        {
          let (ip_id_behavior:uncomp_value == 0b10);
        };

        co_format_zero = ip_id_behavior, %[ 2 ]
        {
          let (ip_id_behavior:uncomp_value == 0b11);
        };
};

Can somebody explain to me what this is supposed to do - because I don't
think it does what it's supposed to (though I think the fix is quite easy).

As an aside, it is odd seeing the behaviour flags written in binary here
when they are in decimal in the preceding format (ip_id_enc_irreg). I think
it would be clearer if we stuck to using a single number base for a
particular attribute like this - or is there some significance of the actual
bits here that we don't need to see elsewhere (in which case a comment might
be useful)? Minor point, but I thought I'd mention it since I noticed it.

Cheers

Raffles

_______________________________________________
Rohc mailing list
Rohc at ietf.org
https://www1.ietf.org/mailman/listinfo/rohc