[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Simple] Comments Event Filter Function -01



Hi Hisham,

I have the following comments on the subject draft:

1) Section 3.3.3 : Changing Filters Within a Dialog

First, small typo -  3 lines from the bottom:  "changing" instead of "chaning".
Next, why do we want to consider an error condition the case when a new filter is defined with new contents but reference an existing  resource (that already had a previuosly defined filter wih a different filter id).
Why not simply remove the old filter for that resource and replace that with the newly defined filter for that resource.
Otherwise the only way to define a new filter for such a resource would be to explictly remove the old filter first then define a new one.
This way you have uniform treatment for all cases.

If you are OK with that one, then there are several  places in the draft where that needs to be reflected.

2) Section 4.1

First, can you please add the following clarification to the text in the second paragraph

 If no URI is indicated by the filter, the filter applies to all the
   notifications that the RLS issues for the R-URI. 
 If the URI indicated by the filter is a list URI, the filter applies to all the notifications
   that the RLS issues for the list in the filter URI.

Next, in the third paragraph, you have the example on myboddies at mydomain.com & bob at mydomain.com, it seems to me that the domain must be different for the RLS to extract the filter and propagate it, so Bob should have a different domain for the statement to apply. 

Finally, in the paragraph  before the last one, where the filter applies to a domain, you state that the RLS MUST NOT apply any filter to any notifications it sends, but instead MUST forward the filter with all fanned oiut subscriptions to the notifiers. 
You should qualify that statement, that it only applies if the domain is a different domain then the one that to which the RLS belongs.

3) Section 4.2
Minor typo , fourth line from the bottom:  "of" instead of "oif".

4) Section 5.2

Minor typo first line: "additional"  instead of "addition"

5) Section 5.3.1
Fist paragraph, you state that the NOTIFY being sent after a 2xx
   response to the original SUBSCRIBE MUST be populated
   according to the filter.  

Using a strength of *MUST* contradicts what you state in section 5.3 that the NOTIFY  following a 202 could be used to terminate the subscription.

Align the 2 sections.

Rgds/gf



_______________________________________________
Simple mailing list
Simple at ietf.org
https://www1.ietf.org/mailman/listinfo/simple