[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Sip] draft-sparks-sip-invfix-02
(sorry for the lag)
All fixes incorporated
On Jul 17, 2008, at 8:20 AM, Michael Procter wrote:
> Hi Robert,
>
> On Thu, July 3, 2008 6:32 pm, Robert Sparks wrote:
>> Please review this carefully. (We really need a _lot_ of people to
>> think about it, not just a few).
>
> I've been through this draft recently, and it broadly matches up to
> the
> changes we have been using successfully for a while now (modulo some
> implementation details). I only have a few minor comments:
>
> Figure 2:
> This might be a minor typo, or I may have completely misunderstood the
> draft. Should the state labelled 'Completed' actually be labelled
> 'Accepted'?
>
> 8.4 para 7:
> The first sentence is a little awkward. It currently contains
> 'the "Accepted" state, The client'
>
> Obvious fixes are either
> 'the "Accepted" state. The client'
> or
> 'the "Accepted" state, the client'
> but both end up with the sentence sounding a bit clumsy.
>
> You could replace the entire sentence with something like this:
> When in either the "Calling" or "Proceeding" states a 2xx response
> is
> received, the client transaction MUST transition to the "Accepted"
> state, and Timer M MUST be started with a value of 64*T1. The 2xx
> response MUST be passed up to the TU.
>
> Minor typos
> ===========
> 7.1 para 2:
> "transisition" should be "transition"
>
> 7.3 para 1:
> "any response SIP response" should be "any SIP response"
>
> Figure 3:
> "Timer B fired" should be "Timer B fires" (and used to be)
>
> 8.10 Timer M:
> "retranmission" should be "retransmission"
>
> Best regards,
>
> Michael
>
_______________________________________________
Sip mailing list https://www.ietf.org/mailman/listinfo/sip
This list is for NEW development of the core SIP Protocol
Use sip-implementors at cs.columbia.edu for questions on current sip
Use sipping at ietf.org for new developments on the application of sip