[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[VCARDDAV] vcardrev nits

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Herewith some nits regarding draft-ietf-vcarddav-vcardrev-08. I might
have more substantive comments regarding synchronization.

0. Abstract

The reference to "individuals" might be taken to imply that vCards are
only for humans, which I think they are not. Indeed, there is an old
tradition in the Jabber community of assigning vCards to servers for
geolocation purposes.

1. Introduction

This text is worrisome...

   Note: This draft contains much of the same text as 2425 and 2426
   which may not be correct.

Is this a specification that is explicitly inaccurate?

Typo: presense => presence

3. MIME Type Registration

Would it simplify things for IANA if this were in the IANA
Considerations section?

4.1. Line Delimiting and Folding

   At least one character must be present on the
   folded line.

I suggest:

   The folded line MUST contain at least one character.

4.2. ABNF Format Definition

The comment on the contentline field contains normative text:

       ; When parsing a content line, folded lines MUST first
       ; be unfolded according to the unfolding procedure
       ; described above.

This strikes me as an odd place to put normative text.

5.3. DATE, TIME, DATE-TIME, DATE-AND-OR-TIME, and TIMESTAMP

   based on a the definitions

should be

   based on the definitions

6. Property Parameters

   Applications MUST ignore x-param and iana-param value they don't
   recognize.

should be

   Applications MUST ignore x-param and iana-param values they don't
   recognize.

7.1.5. KIND

   Special notes:  The value may be one of: "individual" for a single
      person, "group" for a group of people, "org" for an organization,
      "location" for a named geographical place, an x-name or an iana-
      token.  If this property is absent, "individual" MUST be assumed
      as default.

What about devices, servers, and other entities?

(Compare to 7.2.3 NICKNAME, which at least mentions the possibility that
the entity could be a "thing".)

7.2.4. PHOTO

   The full
   media type name, including the "image/" prefix, should be used.

Change "should" to "SHOULD"?

(Same for LOGO and SOUND.)

7.2.10. SEX

aplicable => applicable

7.3.2. LABEL

   corresponding to delivery address

should be

   corresponding to a delivery address

7.4.1. TEL

prefered-use => preferred-use

cellular telephone number => cellular or mobile telephone number

      parameter values can be specified as a parameter list (i.e.,
      "TYPE=text;TYPE=voice") or as a value list (i.e.,
      "TYPE=text,voice")

I would change "i.e." to "e.g." because these are merely examples.

7.4.3. IMPP

Would a reference to RFC 4770 be appropriate?

7.5.1.  TZ

I still think it would be nice to have a field for offset from UTC.

7.6.3. LOGO

   Encoding:  The encoding MUST be reset to "b" using the ENCODING
      parameter in order to specify inline, encoded binary data.  If the
      value is referenced by a URI value, then the default encoding of
      8bit is used and no explicit ENCODING parameter is needed.

   Value type:  A single value.  The default is binary value.  It can
      also be reset to uri value.  The uri value can be used to specify
      a value outside of this MIME entity.

This strikes me as contradictory -- the "default is binary value" yet
"the encoding MUST be reset to "b" using the ENCODING parameter in order
to specify inline, encoded binary data"?? Why is it necessary to reset
the ENCODING parameter to "b" if the default is binary? (The same
comment applies to 7.7.6 SOUND and 7.8.2 KEY.)

7.6.5. MEMBER

tpe => type

7.6.6. RELATED

represents has => has

   "child" means the opposite of "parent"

Hot is the opposite of cold, high is the opposite of low, but child is
the opposite of parent? I recommend:

   "child" means that the related individual is the child of the
   individual this vCard represents.

We might also mention that a child does not need to be a natural,
biological child (adopted child, stepchild, etc.).

7.7.1. CATEGORIES

Is a category essentially the same as a "tag"?

7.7.3. PRODID

assure => ensure

7.7.5. SORT-STRING

   locale- or national-language- specific sorting

This is hard to parse. I suggest:

   The sort string is used to provide family name or
   given name text that is to be used in sorting of
   the formatted name and structured name types in the
   context of a particular locale or national language.

7.9.1. FBURL

   last six weeks

Is the definition of FBURL really that specific?

it's => its

7.9.3 CALURI

it's => its

8. Synchronization

As noted, I might have more substantive comments on this section.

8.1.1.  Matching vCard Instances

   vCard instances for which the UID properties (Section 7.7.7) are
   equivalent MUST be matched.

Is it not an option to punt on matching?

10. Security Considerations

The mention of Internet mail is jarring. Perhaps first mention that
vCards are often used to transport vCards?

   In cases where threats of "spoofed" vCard information is a concern

should be

   In cases where the threat of "spoofed" vCard information is a concern

11.1 MIME Type Registration

[see comment above]

Peter

- --
Peter Saint-Andre
https://stpeter.im/


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqwB5EACgkQNL8k5A2w/vxk0QCfXrkTgaVj9OyQl1FQ27lFd0SE
3RoAoKD0GQUKBOAxnnD0sSdVOkoeY1ir
=VkOV
-----END PGP SIGNATURE-----