This is my YANG doctor's review of draft-ietf-anima-brski-prm-05.

From a YANG perspective, this module is quite simple and looks good.  The only thing you should change
is to use sx:structure (from RFC 8791) instead of rc:yang-data.

However, you wrote in the request for the review "we would want to use this document as the spearhead for resolving our issue of augmenting rfc8366 YANG".  I have read the thread on the netmod mailing list,
but I am not sure I understand the problem correctly.  In the ML thread, there was the example of two independent modules that augmented RFC8366:

  module B adds some leafs to RFC8366
  module C adds some leafs to RFC8366

If both B and C defines *new* distinct structures, then the approach with groupings and specific structures in B and C is correct.

But if the intention is to add leafs to the *existing* structure defined in RFC 8366 ("voucher-artifact"), then this approach doesn't work.  If this is the intention, the base structure needs to be defined with sx:structure, and
B and C would have to use sx:augment-structure to add their leafs.  This approach would e.g. allow an implementation to instantiate a "voucher-artifact" structure with leaves from *both* B and C, even though they are independent modules.


/martin