IETF Logo Mail Archive

[Gen-art] Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07

"jouni.nospam" <jouni.nospam@gmail.com> Sun, 16 October 2016 21:50 UTC

Return-Path: <jouni.nospam@gmail.com>
X-Original-To: gen-art@ietfa.amsl.com
Delivered-To: gen-art@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id EDA151294E0; Sun, 16 Oct 2016 14:50:29 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -2
X-Spam-Level:
X-Spam-Status: No, score=-2 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id x5vuZxg8e1_9; Sun, 16 Oct 2016 14:50:28 -0700 (PDT)
Received: from mail-pf0-x229.google.com (mail-pf0-x229.google.com [IPv6:2607:f8b0:400e:c00::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id A68431294C1; Sun, 16 Oct 2016 14:50:25 -0700 (PDT)
Received: by mail-pf0-x229.google.com with SMTP id r16so47272400pfg.1; Sun, 16 Oct 2016 14:50:25 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:content-transfer-encoding:subject:date:message-id:cc:to :mime-version; bh=st/xgn+VstKVPrOIa83ZkpvMzCo34CF7uUkAhzhT+gg=; b=ouHLZ2zu8RFt19Cp5oUaON69ypTAfaE3G3Ibwc1+KlCg0s+qyY5gC3WqRHJDrX7i2M V2p0sOm0XuAAJHcFfJsdaA35zze7Pih+VycPY56TndJQ8eOZ61FJYRg+6iGNR0vi4sX4 vaUrRt2vjN48W3FbRl1QNQW4ZUExMqyK0ZigNYrw1aiuMJDExTLihlymzV1pkEeSAOP0 MIQmxl9xrktTDkA/DSmi5PR4f0n5B9iv4w+Xkoniqem5/orkbPq4zodZZZ5M65rIaxIH RkPar8EbLfA1xC8o8iE5NJ9jM6cjr/V6SQf/3dALBWksC1rFF/oBZlTd08T8i4crTp+s AVlQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:content-transfer-encoding:subject:date :message-id:cc:to:mime-version; bh=st/xgn+VstKVPrOIa83ZkpvMzCo34CF7uUkAhzhT+gg=; b=bRiN5gSZXbzHcPaL3CcMKAtW/30KvWdIWMXHPPpkRSsRZh0AhbeWktyz8q9DnUCPfd 8TAMLPr1q61kL6deCkybjZjok8mEymbUSnIc0zKBM+dsv2Mdgle9wyypxAjdRraJZDg6 Ix0G7t4UEYBqumSIq8cUuO/xs36ndEcbLL5lSQz/diG0VIXi/Yqx6V1mkOT+v+N9ujL/ w/fw+i7zoX05VGHHbfR1fCmebr6yP4X1A8o8dv6oEejonsHUP9B7wojBJr3TNCsaCW4f ZWFhYoaYCQf3UGtzyQhCa7zAp2rhockOZun1sgZcL0WACDYnAzEatcMiPCCnG2hkhaCv hklw==
X-Gm-Message-State: AA6/9Rmu/EgoDKZcn37vlDamJHEoBDUeoZP8qrBGpdoxiXW+ZS6wTokHwm9uPj8hzx3AqA==
X-Received: by 10.99.97.69 with SMTP id v66mr27221991pgb.5.1476654624783; Sun, 16 Oct 2016 14:50:24 -0700 (PDT)
Received: from ?IPv6:2601:647:4200:e520:b408:f6dc:7606:8b2e? ([2601:647:4200:e520:b408:f6dc:7606:8b2e]) by smtp.gmail.com with ESMTPSA id a9sm42588606pfa.38.2016.10.16.14.50.23 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 16 Oct 2016 14:50:23 -0700 (PDT)
From: "jouni.nospam" <jouni.nospam@gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Date: Sun, 16 Oct 2016 14:50:21 -0700
Message-Id: <499E4913-F08F-439A-82CA-68F91F507E5D@gmail.com>
To: gen-art@ietf.org
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
X-Mailer: Apple Mail (2.3124)
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/4TCl2x09huAaSgLj-LEjSQzoJhE>
Cc: draft-ietf-ccamp-ospf-availability-extension.all@ietf.org
Subject: [Gen-art] Gen-ATR review of draft-ietf-ccamp-ospf-availability-extension-07
X-BeenThere: gen-art@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/gen-art>, <mailto:gen-art-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art/>
List-Post: <mailto:gen-art@ietf.org>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/gen-art>, <mailto:gen-art-request@ietf.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Oct 2016 21:50:30 -0000

I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<http://wiki.tools.ietf.org/area/gen/trac/wiki/GenArtfaq>.

Document: draft-ietf-ccamp-ospf-availability-extension-07
Reviewer: Jouni Korhonen
Review Date:        2016-10-16
IETF LC End Date:   2016-10-24
IESG Telechat date: 2016-11-03

Summary:

Document is ready with nits.

Major issues:

None.

Minor issues:

It is not clear to me how the ISCD Availability sub-TLV is encoded into RFC4203 Switching Capability-specific information field. This is because RFC4203 lists specific encodings depending on “Switching Cap” field and those encoded information fields seem not to be TLVs. I would like to see some text that deals with switching cap, its relation to the TLV described in this document and the coexistence with existing capability specific information fields described in RFC4203. If I did not understand something regarding the encoding that is supposed to be trivial I am happy to told that ;)

Nits/editorial comments:

o Line 21: ISCD is not expanded.
o Line 142: unnecessary extra space in "a < availability”.
o Line 150: Space needed before the reference "protocol[ETPAI].”
o Line 142-.. TE is never expanded or part of the list acronyms.
o Lines 176-178: formatting issue with indentation, line spacing  and 
  line endings (not a fullstop but ‘;’).
o Line 162: TLV is never expanded or  part of the list acronyms.

__________________________________________

v2.23.0 | Report a Bug | By Email