[Idr] RtgDir QA review on draft-ietf-idr-bgp-gr-notification-07

Mach Chen <mach.chen@huawei.com> Wed, 15 June 2016 09:42 UTC

From: Mach Chen <mach.chen@huawei.com>
To: "draft-ietf-idr-bgp-gr-notification@tools.ietf.org" <draft-ietf-idr-bgp-gr-notification@tools.ietf.org>, Susan Hares <shares@ndzh.com>, "'John G. Scudder'" <jgs@juniper.net>
Thread-Topic: RtgDir QA review on draft-ietf-idr-bgp-gr-notification-07
Thread-Index: AdHG6PR/x2LfjUXuTCG85tlH1QdySg==
Date: Wed, 15 Jun 2016 09:33:21 +0000
Message-ID: <F73A3CB31E8BE34FA1BBE3C8F0CB2AE28CC815B2@SZXEMA510-MBX.china.huawei.com>
Accept-Language: en-US, zh-CN
Content-Language: zh-CN
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Archived-At: <https://mailarchive.ietf.org/arch/msg/idr/kqoI3zsgl8V5ULjveUroTtIdzio>
Cc: Jonathan Hardwick <Jonathan.Hardwick@metaswitch.com>, "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "idr@ietf.org" <idr@ietf.org>, "Zhangxian (Xian)" <zhang.xian@huawei.com>, "rtg-ads@tools.ietf.org" <rtg-ads@tools.ietf.org>
Subject: [Idr] RtgDir QA review on draft-ietf-idr-bgp-gr-notification-07
Precedence: list

Hi Authors,

I was assigned to do a QA review on draft-ietf-idr-bgp-gr-notification-07. For more detail what's is RtgDir QA review, please refer to https://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDirDocQa

Overall, the document is well-written and clear, after review, I have the following comments.

1. Abstract
s/BGP NOTIFICATION Message/ BGP NOTIFICATION message;

2. Section 2:
"
Flags for Address Family:

This field contains bit flags relating to routes that were
advertised with the given AFI and SAFI.

0 1 2 3 4 5 6 7
+-+-+-+-+-+-+-+-+
|F|N| Reserved |
+-+-+-+-+-+-+-+-+

The usage of second most significant bit "N" (which was defined in a
previous draft version of this specification) is deprecated. This
bit MUST be advertised as 0 and MUST be ignored upon receipt.
"
The "N" bit was firstly introduced in a previous version of this document, but deprecated in later version. I don't understand why a document need deprecate a functionality introduced by itself, why not just remove it? If we really want to keep this history, maybe a better way is to move above text to an appendix.

If you agree above, then the last sentence of the first paragraph of section 2 should be changed as bellow:

OLD:
"the Restart flags field and the Flags field for Address Family are augmented as follows:"

New:
"the Restart flags field are augmented as follows:"

3. Section 3.1

"Subcode is a BGP Error Subcode (as documented in the IANA BGP Error
Subcodes registry) as appropriate for the ErrCode. Similarly, Data
is as appropriate for the ErrCode and Subcode."
This is just an introduction to the Subcode itself, it's better to explicitly state that the subcode should be set to the Hard Reset (9).

Hope you find above review useful.

Best regards,
Mach

[Idr] RtgDir QA review on draft-ietf-idr-bgp-gr-n… Mach Chen