IETF Logo Mail Archive

[RTG-DIR] RtgDir review: draft-ietf-mpls-rfc4379bis-06

Daniele Ceccarelli <daniele.ceccarelli@ericsson.com> Tue, 27 September 2016 09:00 UTC

Return-Path: <daniele.ceccarelli@ericsson.com>
X-Original-To: rtg-dir@ietfa.amsl.com
Delivered-To: rtg-dir@ietfa.amsl.com
Received: from localhost (localhost [127.0.0.1]) by ietfa.amsl.com (Postfix) with ESMTP id B1E2712B095; Tue, 27 Sep 2016 02:00:49 -0700 (PDT)
X-Virus-Scanned: amavisd-new at amsl.com
X-Spam-Flag: NO
X-Spam-Score: -4.22
X-Spam-Level:
X-Spam-Status: No, score=-4.22 tagged_above=-999 required=5 tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=ham autolearn_force=no
Authentication-Results: ietfa.amsl.com (amavisd-new); dkim=pass (1024-bit key) header.d=ericsson.onmicrosoft.com
Received: from mail.ietf.org ([4.31.198.44]) by localhost (ietfa.amsl.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vq5ezHON8ih0; Tue, 27 Sep 2016 02:00:47 -0700 (PDT)
Received: from sessmg22.ericsson.net (sessmg22.ericsson.net [193.180.251.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ietfa.amsl.com (Postfix) with ESMTPS id 57D8912B09F; Tue, 27 Sep 2016 02:00:43 -0700 (PDT)
X-AuditID: c1b4fb3a-aa3ff7000000099a-13-57ea353867d3
Received: from ESESSHC014.ericsson.se (Unknown_Domain [153.88.183.60]) by (Symantec Mail Security) with SMTP id 10.3F.02458.8353AE75; Tue, 27 Sep 2016 11:00:41 +0200 (CEST)
Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.60) with Microsoft SMTP Server (TLS) id 14.3.301.0; Tue, 27 Sep 2016 11:00:39 +0200
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.onmicrosoft.com; s=selector1-ericsson-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=QexV0Ab1ftNd/Eb8pe9fLN6Q/i9E62SCDfAixrYdTPo=; b=BMA3Dd4PrjDwELVoOC0N+N/fXuJKICDyCF+vfzmuTQb8HvRfeBFYvsnGHqws6mcWPPQSl6x5jsxBf8mwXqYuOumrkpwZITkdkIH6iPW33KdTTPy9eJnSGYH2wwB8d+DMUq4epr2ZSuoajDJoFhOEFt0s6qMaznACzDF0IzuU5pg=
Received: from AM2PR07MB0994.eurprd07.prod.outlook.com (10.162.37.152) by AM2PR07MB0996.eurprd07.prod.outlook.com (10.162.37.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.639.5; Tue, 27 Sep 2016 09:00:38 +0000
Received: from AM2PR07MB0994.eurprd07.prod.outlook.com ([10.162.37.152]) by AM2PR07MB0994.eurprd07.prod.outlook.com ([10.162.37.152]) with mapi id 15.01.0639.011; Tue, 27 Sep 2016 09:00:38 +0000
From: Daniele Ceccarelli <daniele.ceccarelli@ericsson.com>
To: "<rtg-ads@ietf.org> (rtg-ads@ietf.org)" <rtg-ads@ietf.org>
Thread-Topic: RtgDir review: draft-ietf-mpls-rfc4379bis-06
Thread-Index: AdIYlGctmue+loOwTiq6Dd9Tc8UYiA==
Date: Tue, 27 Sep 2016 09:00:38 +0000
Message-ID: <AM2PR07MB09942196213D9DC0F539DABFF0CC0@AM2PR07MB0994.eurprd07.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
authentication-results: spf=none (sender IP is ) smtp.mailfrom=daniele.ceccarelli@ericsson.com;
x-originating-ip: [2.112.192.21]
x-ms-office365-filtering-correlation-id: cb379418-d90f-4021-36f4-08d3e6b4c0a3
x-microsoft-exchange-diagnostics: 1; AM2PR07MB0996; 6:xAOC6jJrjpf/naCdxtpbywHXm3da9d6RTZT7+nzxdzLCjAZ74ygtp5b4UHNcISzbbR7aF1h6AJN1nNszIPK91SFPr0Ly/YTsvr7snX+7Sr92Kxa6GMfe0cgG+ckFfAs8AHadxwE2LxQembqk/wiHJkuSqSCFgKC1twZa2YUjHaGPromTy35zj3PPhj+QM2r3/pyppiWo9siI7NIS69fxqkHqhhLddQLplzVDu9UbAUHyDJiGNz4/LVokw+2mhnO9uyU81ItKbzGleGGUfgceIPZ7QfPSvFuqlM8loHU8IV4=; 5:c5YIS1/yMivxhR9I65xdaNranc+jTsNIB9BAbQlFf7gOYHt4unr7l7xE91P3pRNErdNA0KbslXu4n5BZnYuiGdoRDcnA8ydvCVbNcLxXX8/IHU8Ijz2InKQjMrGzh4XyYikVl7kOOqEBLM15cApXwA==; 24:rXnTwTjW3vAcPKumZGHyYkZHwWiT1aqclCItoYtLcc+0VKimJDr+nMX5boszsfTtNPNe2mOEtp2CfMLnFTOM94CEeZGKIU1nchEo9sgwxjQ=; 7:HrVD+VzAbcLJ0/XbCf3WwAL0QaFOZsuKHs9vCw5QgGdY9wQGK5vCcVRvKD2NqEnrgrEmPycaW6NyRVH1uLse8RsjHhPeT/KsgCIiOprz1r0McZfONHiGwbvTZHEsJ5aB3qVyJXWaK4dO4YjtBprJRKun7FzlZ1N8bc6YGouI/U+2EvRSPINWwRwalBkdMlc9krbS8nM0XLyG6OvAvVJvIZ4sCDPUnmPuVcLF/0SPndTlgnRtG9eq6wc/j+SMnnUBFXeYyzaHefGdvQGwrRKFdnvr/g0MTd3QMaafUDJff929pn5zx4FSb4hs6Aqpo4gw
x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR07MB0996;
x-microsoft-antispam-prvs: <AM2PR07MB0996F5B6F8001854F99A28E4F0CC0@AM2PR07MB0996.eurprd07.prod.outlook.com>
x-exchange-antispam-report-test: UriScan:(100405760836317)(21748063052155);
x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046); SRVR:AM2PR07MB0996; BCL:0; PCL:0; RULEID:; SRVR:AM2PR07MB0996;
x-forefront-prvs: 007814487B
x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(7916002)(37854004)(199003)(189002)(16236675004)(3660700001)(101416001)(19580395003)(19300405004)(76576001)(105586002)(4326007)(106356001)(5002640100001)(87936001)(11100500001)(229853001)(66066001)(97736004)(5660300001)(189998001)(68736007)(10400500002)(19625215002)(3280700002)(7696004)(8936002)(15975445007)(74316002)(2900100001)(86362001)(110136003)(50986999)(54356999)(122556002)(2906002)(33656002)(77096005)(7846002)(790700001)(19617315012)(7906003)(102836003)(6116002)(3846002)(230783001)(81166006)(7736002)(81156014)(9686002)(8676002)(586003)(450100001)(92566002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM2PR07MB0996; H:AM2PR07MB0994.eurprd07.prod.outlook.com; FPR:; SPF:None; PTR:InfoNoRecords; A:1; MX:1; LANG:en;
received-spf: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: multipart/alternative; boundary="_000_AM2PR07MB09942196213D9DC0F539DABFF0CC0AM2PR07MB0994eurp_"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Sep 2016 09:00:38.8475 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 92e84ceb-fbfd-47ab-be52-080c6b87953f
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR07MB0996
X-OriginatorOrg: ericsson.com
X-Brightmail-Tracker: H4sIAAAAAAAAA02SfUhTYRTGe3fv3a6j4evSPKlBTiJT1CUZJuIHRBSaFUbrE115UVOn7Zql +IdBo3SUGtpwGCppftbSHA0/yC0cakFJBTI1PzJTG0gj0iVUXu8i//ud8zznvDyHlyak7ZQP nanKZ9QqZbZMKCZrzryIDjkYsaSQa98HRy4M4EhbUysVOVy7SkTWd3wRxZFHGhudghPonDg6 jcnOLGDUYTGp4oyJ76NU3rwD3dC9eUCWoG47KkNuNOD9MHmvmuRYig0IDG1Xy5B4nYcQDPYu kFxB4rsE3DGbCV6pEsBkZ5OAL6wINNM6qgzRtBBHwZwlkUNPHAP60RDOQuBHCEwNg0LuiW04 AvTGzg32XLebZ36KeA6FqbVnFMck3g3m5yUEt0eCL4DZ6cu1Ed4OKyMdAo4J7A22uToBnwBD Y99bgmcvWPz8m+L9l8CgMbk8u+BTl1XI8zFwasY3ggF+KgJn8zTFC4dhudLmOksWzAwNuYYT YEk3j/gBE4LSnlXXJj+wV3wT8sIPCoadJRR/SAaan2gQn9gHJj+UutgPFib6N45F4FywvC6q QHv0mwLp/ytcW4I9YLhmjuTbe8HQE8a7/aFKOyPiORA0tQ9Fm/v1SNSGvFiGZXPSw8NDGXXm ZZbNVYWqmPwutP6FzN1rUSZk/hpvQZhGsq2SVP2iQkopC9jCHAsCmpB5ShzyJYVUkqYsLGLU uSnqa9kMa0G+NCnzlhxonVJIcboyn8limDxG/U8V0G4+JSixt7vplXGHlcmrKR+/HnE/fqC6 Zeziy7mO/ir3U+KR8nHdrDWwOO5jckObNmfMQRYc2qJcTjau7HS8a0mVBxyXX/EYibHdlLMd lWN/FOfTc7SB7rH5/oOPY/NMfqO/7Kdng04W1zfYjV7B9tutRWcDko62pyTA2q2pedN4Ul2f jGQzlPuCCDWr/As58rtSPgMAAA==
Archived-At: <https://mailarchive.ietf.org/arch/msg/rtg-dir/80iCNzE56x19LKzIMXyzBoE08GY>
Cc: "rtg-dir@ietf.org" <rtg-dir@ietf.org>, "draft-ietf-mpls-rfc4379bis.all@ietf.org" <draft-ietf-mpls-rfc4379bis.all@ietf.org>, "mpls@ietf.org" <mpls@ietf.org>
Subject: [RTG-DIR] RtgDir review: draft-ietf-mpls-rfc4379bis-06
X-BeenThere: rtg-dir@ietf.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Routing Area Directorate <rtg-dir.ietf.org>
List-Unsubscribe: <https://www.ietf.org/mailman/options/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=unsubscribe>
List-Archive: <https://mailarchive.ietf.org/arch/browse/rtg-dir/>
List-Post: <mailto:rtg-dir@ietf.org>
List-Help: <mailto:rtg-dir-request@ietf.org?subject=help>
List-Subscribe: <https://www.ietf.org/mailman/listinfo/rtg-dir>, <mailto:rtg-dir-request@ietf.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Sep 2016 09:00:50 -0000

Hello,

I have been selected as the Routing Directorate reviewer for this draft. The Routing Directorate seeks to review all routing or routing-related drafts as they pass through IETF last call and IESG review, and sometimes on special request. The purpose of the review is to provide assistance to the Routing ADs. For more information about the Routing Directorate, please see ​http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir<http://trac.tools.ietf.org/area/rtg/trac/wiki/RtgDir>

Although these comments are primarily for the use of the Routing ADs, it would be helpful if you could consider them along with any other IETF Last Call comments that you receive, and strive to resolve them through discussion or by updating the draft.

Document: draft-ietf-mpls-rfc4379bis-06
Reviewer: Daniele Ceccarelli
Review Date: 27/09/2016
IETF LC End Date: date-if-known
Intended Status: Standard Track

When I saw that the document was obsoleting 4 well known and widely deployed documents I was scared, but reading the shepherd write up it seems that the drafts got a wide consensus in the working group.

Summary:
No issues found. This document is ready for publication.

Comments:

The document is well written and comprehensible, but I didn’t expect less from such a dream team of authors.

Major Issues:

  *   "No major issues found."

Minor Issues:

  *   Backward compatibility. I would expect to see a section with some backward compatibility issues. Probably since all the previously defined methods and extensions are deprecated no backward compatibility is expected? In any case it is worth mentioning it.
  *   3.2.8.  FEC 128 Pseudowire - IPv4 (Deprecated) vs. 3.2.9.  FEC 128 Pseudowire - IPv4 (Current). I don’t understand this. Is there a deprecated version of the FEC 128 PW and a current one? Where is that deprecated? I don’t think there is the need to address both but just the current one.

Nits:

  *   I think this sentence can be removed from the Abstract “This document obsoletes RFCs 4379, 6424, 6829, and 7537.”
  *   Introduction:  “An important consideration in this design is that MPLS echo requests follow the same data path that normal MPLS packets would traverse.” I guess this is mandated by other documents, please add a reference, otherwise this is a strong requirement that need to be specified with RFC2119 terminology.
  *   Motivation: (ICMP echo request [RFC0792]. It’s nice to have all the references in 4 digits, but I guess the 0 is not needed at this time.
  *   Section 2: “is a pure RSVP node and doe not run LDP” s/does/doe
BR
Daniele

v2.23.0 | Report a Bug | By Email